Skip to content

♻️ Improve exception handling & logging in splitter #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MiWeiss merged 2 commits into from
Jan 14, 2026
Merged

♻️ Improve exception handling & logging in splitter #506

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee0f0e7
♻️ Improve exception handling in splitter
MiWeiss Jan 14, 2026
3272a3f
Merge branch 'main' into fix/improve-exception-handling-splitter
MiWeiss Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions bibtexparser/splitter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,8 +291,8 @@ def split(self, library: Optional[Library] = None) -> Library:
f"due to syntactical error in bibtex:\n {e.abort_reason}"
)
logger.info(
"We will try to continue parsing, but this might lead to unexpected results."
"The failed block will be stored in the `failed_blocks`of the library."
"We will try to continue parsing, but this might lead to unexpected results. "
"The failed block will be stored in the `failed_blocks` of the library."
)
library.add(
ParsingFailedBlock(
Expand All @@ -308,14 +308,14 @@ def split(self, library: Optional[Library] = None) -> Library:
"python-bibtexparser detected an invalid state. Please report this bug."
)
logger.error(e.message)
raise e
except Exception as e:
raise
except Exception:
# For unknown exceptions, we want to fail hard and get the info in our issue tracker.
logger.error(
f"Unexpected exception while parsing `{m_val}` block (line {start_line})"
f"Unexpected exception while parsing `{m_val}` block (line {start_line}). "
"Please report this bug."
)
raise e
raise

self._reset_block_status(current_char_index=self._current_char_index + 1)
else:
Expand Down
Loading