Skip to content

✨ Add type checking for encoder/decoder parameters #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MiWeiss merged 2 commits into from
Jan 14, 2026
Merged

✨ Add type checking for encoder/decoder parameters #508

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a16a42
✨ Add type checking for encoder/decoder parameters
MiWeiss Jan 14, 2026
885836d
Merge branch 'main' into fix/add-type-checking-latex-encoding
MiWeiss Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions bibtexparser/middlewares/latex_encoding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,15 @@ def __init__(

if encoder is not None and (keep_math is not None or enclose_urls is not None):
raise ValueError(
"Cannot specify both encoder and keep_math or enclose_urls."
"Cannot specify both encoder and keep_math or enclose_urls. "
"If you want to use a custom encoder, you have to specify it completely."
)

if encoder is not None and not isinstance(encoder, UnicodeToLatexEncoder):
raise TypeError(
f"encoder must be a UnicodeToLatexEncoder instance, got {type(encoder).__name__}"
)

# Defaults (not specified as defaults in args,
# to make sure we can identify if they were specified)
keep_math = keep_math if keep_math is not None else True
Expand Down Expand Up @@ -167,11 +172,16 @@ def __init__(
if decoder is not None and (keep_braced_groups is not None or keep_math_mode is not None):
raise ValueError(
"Cannot specify both decoder and one of "
"`keep_braced_groups` or `keep_math_mode`."
"`keep_braced_groups` or `keep_math_mode`. "
"If you want to use a custom decoder, "
"you have to specify it completely."
)

if decoder is not None and not isinstance(decoder, LatexNodes2Text):
raise TypeError(
f"decoder must be a LatexNodes2Text instance, got {type(decoder).__name__}"
)

# Defaults (not specified as defaults in args,
# to make sure we can identify if they were specified)
keep_braced_groups = keep_braced_groups if keep_braced_groups is not None else False
Expand Down
Loading