Skip to content

Conversation

@AnouarBe
Copy link

@AnouarBe AnouarBe commented Mar 2, 2013

Hello Scott,

I'm glade to use your tool and also to contribute to improve it (I hope).

First, it's the first time I use Git (I'm an old subversion user) this why the push contains so mush changes in the same time (This won't be case after).

So, here is what I did :

  • Added some comments
  • Splited the 'execute' function in two parts : run_{src,dst}_job, this helps me to understand your philosophy
  • Changed some parameters to be more explicit
  • Add the use of the 'argparse' module
  • Add --exclude option to exclude dirs from the backup
  • Changed the s.st_mtime to int(s.st_mtime) as I discovered a strange behaviour when bucking up a second time the same directory

Everything I tested was ok and I'm happy with it.

Regards,
Anouar

+ Added some comments
+ Changed some parameters to be more explicit
+ Add the use of the module argparse
+ Add --exclude option to exclude dirs from the backup
@AnouarBe AnouarBe closed this Mar 2, 2013
@AnouarBe AnouarBe reopened this Mar 2, 2013
@scottlu
Copy link
Owner

scottlu commented Mar 16, 2013

Hi Anouar, thank you. I just saw this now, I'll take a look.

@AnouarBe
Copy link
Author

Hello Scott,

I'm writing a patch cause I discoverded that options with - (like ssh-C)
are not well hundled (my fault).
Also, I figured out that when we try to store the / (full FS) the names in
the destination directory are not the same as originals, for example
/home/dir becomes /ome/dir and so on.

Regards.

2013/3/16 Scott Ludwig notifications@github.com

Hi Anouar, thank you. I just saw this now, I'll take a look.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-15012841
.

@AnouarBe AnouarBe closed this Feb 10, 2018
@AnouarBe AnouarBe reopened this Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants