-
Notifications
You must be signed in to change notification settings - Fork 4
Feat: implement hnsw index #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: refactor
Are you sure you want to change the base?
Conversation
e160cf5 to
3a275c3
Compare
HNSW implementation code from my PR on sdslabs/VortexDB sdslabs/VortexDB#43 Signed-off-by: Arshdeep54 <balarsh535@gmail.com>
f883ad4 to
9f8ca6d
Compare
9f8ca6d to
f0e2079
Compare
crates/index/src/hnsw/index.rs
Outdated
| pub(super) fn get_vec(&self, id: PointId) -> &Vec<f32> { | ||
| self.cache | ||
| .get(&id) | ||
| .unwrap_or_else(|| panic!("Vector not found in HNSW cache for id={id}")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to panic here or should it be handled as an error. Just this, else it is good to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added simple error for now, will added detailed one in SNAFU implementations
Signed-off-by: Arshdeep54 <balarsh535@gmail.com>
f0e2079 to
117ccd0
Compare
HNSW implementation referenced from HNSW (Malkov & Yashunin)
Includes the following public functions :