-
Notifications
You must be signed in to change notification settings - Fork 60
[UIK-4653][badge, status-badge] added new compoennt with hardcoded types for some feature statuses #2658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/v17
Are you sure you want to change the base?
Conversation
…me feature statuses
2ab09f9 to
ff56e6e
Compare
semcore/badge/src/Badge.tsx
Outdated
| inverted?: boolean; | ||
|
|
||
| /** | ||
| * @deprecated. Use just type with predefined texts. You should use badge with custom text inside. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Signed-off-by: ilyabrower <ilya-brower@yandex.ru>
…tergalactic into UIK-4653/status-badge
…tergalactic into UIK-4653/status-badge
420f1f3 to
a6407b3
Compare
| "Badge.Alpha": "alpha", | ||
| "Badge.Beta": "beta", | ||
| "Badge.New": "new", | ||
| "Badge.ForYou": "for you", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilyabrower noticed that For You is removed from translations only in EN file, in other languages it still exists
Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: