Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • fix frozen workspace popover

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Jan 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Skipped Skipped Jan 15, 2026 6:05am

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 15, 2026

Greptile Summary

Fixed frozen workspace popover by removing event handlers that blocked normal close behavior and ensuring both the context menu and workspace dropdown close together.

  • Removed onPointerDownOutside and onInteractOutside handlers from context menu PopoverContent that were preventing the popover from closing when clicking outside
  • Added setIsWorkspaceMenuOpen(false) to closeContextMenu function to ensure the workspace dropdown closes along with the context menu

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes correctly address the frozen popover issue by removing event handlers that were blocking normal Radix UI behavior and ensuring proper cleanup of related popover states. The fix is minimal, focused, and follows the expected Radix UI patterns.
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workflow-list/components/context-menu/context-menu.tsx Removed onPointerDownOutside and onInteractOutside event handlers that were blocking normal popover close behavior
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workspace-header/workspace-header.tsx Added workspace dropdown close call to closeContextMenu to ensure both popovers close together

Sequence Diagram

sequenceDiagram
    participant User
    participant WorkspaceDropdown
    participant ContextMenu
    participant RadixUI

    User->>WorkspaceDropdown: Click to open
    WorkspaceDropdown->>RadixUI: Set isWorkspaceMenuOpen=true
    User->>WorkspaceDropdown: Right-click workspace item
    WorkspaceDropdown->>ContextMenu: Open context menu
    ContextMenu->>RadixUI: Set isContextMenuOpen=true
    Note over ContextMenu: Previously: onPointerDownOutside/onInteractOutside<br/>prevented RadixUI from closing
    User->>RadixUI: Click outside
    RadixUI->>ContextMenu: Trigger close (now works!)
    ContextMenu->>WorkspaceDropdown: closeContextMenu()
    Note over WorkspaceDropdown: New: Also closes workspace dropdown
    WorkspaceDropdown->>RadixUI: Set isWorkspaceMenuOpen=false
    ContextMenu->>RadixUI: Set isContextMenuOpen=false
Loading

@waleedlatif1 waleedlatif1 merged commit 26d0799 into staging Jan 15, 2026
7 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/workspace-popover branch January 15, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants