Skip to content

Fixe the error from Camera flip() #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiapei100 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixe the error from Camera flip() #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/Camera/src/Camera.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ class Camera{
virtual uint8_t* getRGB888(){ return nullptr; };
virtual void setRotation(uint8_t rotation) = 0;
virtual void setInvert(bool invert) = 0;
virtual void flip(bool horiz, bool vert);
virtual void flip(bool horiz, bool vert) = 0;


virtual int width(){ return _width; }
Expand Down
0 .../Sipeed_GC0328/examples/sipeed_gc0328.ino → .../examples/sipeed_gc0328/sipeed_gc0328.ino
View file
Open in desktop
File renamed without changes.
0 ...0328/examples/sipeed_gc0328_binocular.ino → ...328_binocular/sipeed_gc0328_binocular.ino
View file
Open in desktop
File renamed without changes.
5 changes: 5 additions & 0 deletions libraries/Sipeed_GC0328/src/Sipeed_GC0328.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,6 +1202,11 @@ int Sipeed_GC0328::gc0328_get_rgb_gain_db(float *r_gain_db, float *g_gain_db, fl
return ret;
}

void Sipeed_GC0328::flip(bool horiz, bool vert)
{
gc0328_set_hmirror(horiz);
gc0328_set_vflip(vert);
}
int Sipeed_GC0328::gc0328_set_hmirror(int enable)
{
uint8_t data;
Expand Down
1 change: 1 addition & 0 deletions libraries/Sipeed_GC0328/src/Sipeed_GC0328.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ class Sipeed_GC0328 : public Camera{
virtual void setInvert(bool invert);
virtual void shutdown(bool enable);
void setFlip(bool flip);
void flip(bool horiz, bool vert) override;

private:
uint8_t* _dataBuffer; // put RGB565 data
Expand Down