-
Notifications
You must be signed in to change notification settings - Fork 25
PLEX-1920 add solana devnet into default ChainAllowed list #1787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ API Diff Results - No breaking changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds Solana devnet support to the ChainAllowed list to enable E2E testing and integration with related Solana capabilities work.
Changes:
- Added Solana devnet chain selector (16423721717087811551) to the ChainAllowed list
- Reordered chain selectors alphabetically by numeric value
- Updated configuration across Go code, TOML, and JSON settings files
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/settings/cresettings/settings.go | Added solana-devnet chain selector and reordered entries numerically |
| pkg/settings/cresettings/defaults.toml | Added solana-devnet chain selector to TOML configuration |
| pkg/settings/cresettings/defaults.json | Added solana-devnet chain selector to JSON configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d0c1154 to
bdc12ea
Compare
2b52746
| Default = 'false' | ||
|
|
||
| [PerWorkflow.ChainAllowed.Values] | ||
| 12463857294658392847 = 'true' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add mainnet right away?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left main nets out here by design so that we don't accidentally enable anything prematurely. Originally I had this empty, but added minimal dev/testnets to support testing in CI.
8a3fe99
Supports: