Skip to content

Conversation

@Unheilbar
Copy link
Contributor

@Unheilbar Unheilbar commented Jan 21, 2026

@github-actions
Copy link

github-actions bot commented Jan 21, 2026

✅ API Diff Results - No breaking changes


📄 View full apidiff report

@Unheilbar Unheilbar changed the title Plex 1920 add defaults PLEX-1920 add solana devnet into default ChainAllowed list Jan 26, 2026
@Unheilbar Unheilbar marked this pull request as ready for review January 26, 2026 13:52
@Unheilbar Unheilbar requested a review from a team as a code owner January 26, 2026 13:52
Copilot AI review requested due to automatic review settings January 26, 2026 13:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Solana devnet support to the ChainAllowed list to enable E2E testing and integration with related Solana capabilities work.

Changes:

  • Added Solana devnet chain selector (16423721717087811551) to the ChainAllowed list
  • Reordered chain selectors alphabetically by numeric value
  • Updated configuration across Go code, TOML, and JSON settings files

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pkg/settings/cresettings/settings.go Added solana-devnet chain selector and reordered entries numerically
pkg/settings/cresettings/defaults.toml Added solana-devnet chain selector to TOML configuration
pkg/settings/cresettings/defaults.json Added solana-devnet chain selector to JSON configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

silaslenihan
silaslenihan previously approved these changes Jan 27, 2026
ilija42
ilija42 previously approved these changes Jan 29, 2026
jmank88
jmank88 previously approved these changes Jan 29, 2026
silaslenihan
silaslenihan previously approved these changes Jan 30, 2026
jmank88
jmank88 previously approved these changes Jan 30, 2026
Default = 'false'

[PerWorkflow.ChainAllowed.Values]
12463857294658392847 = 'true'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add mainnet right away?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left main nets out here by design so that we don't accidentally enable anything prematurely. Originally I had this empty, but added minimal dev/testnets to support testing in CI.

dhaidashenko
dhaidashenko previously approved these changes Feb 2, 2026
@Unheilbar Unheilbar dismissed stale reviews from dhaidashenko, jmank88, and silaslenihan via 8a3fe99 February 2, 2026 17:28
@jmank88 jmank88 enabled auto-merge February 2, 2026 17:39
@jmank88 jmank88 added this pull request to the merge queue Feb 2, 2026
Merged via the queue into main with commit ee6c9d2 Feb 2, 2026
37 of 39 checks passed
@jmank88 jmank88 deleted the PLEX-1920_add_defaults branch February 2, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants