Skip to content

Conversation

@prashantkumar1982
Copy link
Contributor

The limits just mirror what's there for http-actions capability.

@github-actions
Copy link

github-actions bot commented Jan 30, 2026

✅ API Diff Results - No breaking changes


📄 View full apidiff report

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds per-workflow limit settings for the ConfidentialHTTP capability, mirroring the existing HTTPAction limits so that confidential HTTP calls are governed by the same configuration framework.

Changes:

  • Extend the Workflows schema with a new ConfidentialHTTP section and corresponding confidentialHttp struct, defining call limit, connection timeout, and request/response size limits.
  • Update default configuration sources (defaults.toml, defaults.json) to include PerWorkflow.ConfidentialHTTP defaults aligned with HTTPAction.
  • Update tests and the README’s limits diagram to cover and document the new ConfidentialHTTP settings.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/settings/cresettings/settings.go Adds ConfidentialHTTP to the Workflows schema and defines the confidentialHttp struct and its default values, paralleling HTTPAction.
pkg/settings/cresettings/settings_test.go Extends the schema unmarshal test to include ConfidentialHTTP config and asserts its default call and request size limits.
pkg/settings/cresettings/defaults.toml Adds a [PerWorkflow.ConfidentialHTTP] block with default call, timeout, and size limits.
pkg/settings/cresettings/defaults.json Adds a PerWorkflow.ConfidentialHTTP object mirroring the TOML defaults.
pkg/settings/cresettings/README.md Updates the Mermaid limits diagram to include a PerWorkflow.ConfidentialHTTP subgraph and its bounds.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

RequestSizeLimit Setting[config.Size]
ResponseSizeLimit Setting[config.Size]
}
type confidentialHttp struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type confidentialHttp struct {
type confidentialHTTP struct {

vreff
vreff previously approved these changes Jan 30, 2026
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Feb 3, 2026
Merged via the queue into main with commit 0da324f Feb 3, 2026
35 of 36 checks passed
@prashantkumar1982 prashantkumar1982 deleted the confidential-http-limits branch February 3, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants