-
Notifications
You must be signed in to change notification settings - Fork 25
CapRegistry proto update (OCR config + job spec) #1813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bolekk
wants to merge
1
commit into
main
Choose a base branch
from
ocr-config-capreg-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+414
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ API Diff Results - No breaking changes |
b3c1976 to
37a73c8
Compare
37a73c8 to
b8f769e
Compare
b8f769e to
b2d498b
Compare
bolekk
commented
Feb 3, 2026
|
|
||
| // Oracle factory configs for OCR-based capabilities (moved from job specs). | ||
| // Map key is an OCR instance name (same as above). | ||
| map<string, values.v1.Map> oracle_factory_configs = 10; |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered making this strongly-typed but most fields will be removed anyway.
cedric-cordenier
approved these changes
Feb 3, 2026
jmank88
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to move more config into CapRegistry: