add offchain registry services #279
Conversation
🦋 Changeset detectedLatest commit: 8927794 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
product-security-plaid-production
bot
requested review from
ecPablo and
timothyF95
|
👋 shileiwill, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).
|
| // DownloadArtifact streams a file from the storage service in chunks. | ||
| rpc DownloadArtifact(DownloadArtifactRequest) returns (DownloadArtifactResponse); | ||
| // Cursor/keyset pagination (created_at + workflow_id cursor). | ||
| rpc GetWorkflowListByDONCursor(GetWorkflowListByDONCursorRequest) returns (GetWorkflowListByDONCursorResponse); |
There was a problem hiding this comment.
I'd recommend leaving this method out for now to make it cleaner on which method to consume
patrickhuie19
left a comment
patrickhuie19
left a comment
There was a problem hiding this comment.
Nice! We want only one proto, and already have https://github.com/smartcontractkit/chainlink-protos/pull/255/changes#diff-229d5100eec56f771756db629b6e063032d969bbd23da39879471d4d16b27b56.
I'd suggest we keep the current workflow/sources/v1 dir, but am open to understanding why you created this separately if that was intentional. Note that the client autogenerated by the proto above is used in smartcontractkit/chainlink#20708, which we are merging ASAP. IFIUC, we'd just want to add WorkflowManagedBy to the current defintion.
2 participants
This pull request introduces new offchain registry services to the storage service, expanding its capabilities to support workflow metadata retrieval and listing. The main changes include the addition of new gRPC methods for paginated workflow listing, new proto definitions for workflow metadata, and related updates to generated Go code.
New gRPC API for Workflow Registry:
NodeServiceinnode_service.protofor listing workflows:GetWorkflowListByDONCursor(cursor/keyset pagination)GetWorkflowListByDON(offset pagination) [1] [2]node_service_grpc.pb.goto implement these new methods for both client and server interfaces, including handler functions and service descriptors. [1] [2] [3] [4] [5]Workflow Metadata and Supporting Types:
WorkflowMetadatamessage containing core workflow information (ID, name, owner, status, etc.)WorkflowStatusandWorkflowManagedByenums to standardize workflow state and origin.General/Other Updates:
node_service_grpc.pb.go.go.modto clean up the module file.