Skip to content

core/services: resolve CRE org ID for limits #20933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
jmank88 wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

core/services: resolve CRE org ID for limits #20933

jmank88 wants to merge 1 commit into from

Conversation

@jmank88
Copy link
Contributor

@jmank88 jmank88 commented Jan 26, 2026 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2026

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@jmank88 jmank88 mentioned this pull request Jan 26, 2026
Open
@jmank88 jmank88 force-pushed the CRE-1707-limits-org-id branch from 438196d to 5747b31 Compare January 26, 2026 23:26
trunk-io[bot]

This comment was marked as outdated.

Sign in to view

trunk-io[bot]

This comment was marked as outdated.

Sign in to view

trunk-io[bot]

This comment was marked as outdated.

Sign in to view

trunk-io[bot]

This comment was marked as outdated.

Sign in to view

trunk-io[bot]

This comment was marked as outdated.

Sign in to view

trunk-io[bot]

This comment was marked as outdated.

Sign in to view

trunk-io[bot]

This comment was marked as outdated.

Sign in to view

@trunk-io
Copy link

trunk-io bot commented Jan 27, 2026 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

Failed Test Failure Summary Logs
Test_CRE_V2_EVM_EstimateGas_Invalid_To_Address_Regression/[v2]_EVM.EstimateGas_-_invalid_'to'_address_fails_with_a_letter The test failed because it couldn't create a new node due to a connection refusal when trying to log in to the node's service. Logs ↗︎
Test_CRE_V2_Suite/[v2]_Cron_Beholder_-_workflow-gateway The test failed because it could not connect to a local service at port 10103, causing environment loading to fail. Logs ↗︎
Test_CRE_V2_EVM_FilterLogs_Invalid_FromBlock_Regression/[v2]_EVM.FilterLogs_-_invalid_FromBlock_fails_with_empty_string The test failed because it couldn't connect to the local node, causing environment setup to fail. Logs ↗︎
Test_CRE_V2_EVM_GetTransactionByHash_Invalid_Hash_Regression/[v2]_EVM.GetTransactionByHash_-_invalid_hash_fails_with_short_hash The test failed because it couldn't connect to the local node, causing environment setup to fail. Logs ↗︎

... and 92 more

View Full Report ↗︎ ⋅ Docs

@jmank88 jmank88 requested review from bolekk and jinhoonbang January 27, 2026 14:10
@jmank88 jmank88 force-pushed the CRE-1707-limits-org-id branch 2 times, most recently from c59e556 to dd95795 Compare February 2, 2026 23:22
trunk-io[bot]

This comment was marked as outdated.

Sign in to view

@jmank88 jmank88 force-pushed the CRE-1707-limits-org-id branch from dd95795 to ffff647 Compare February 2, 2026 23:31
trunk-io[bot]

This comment was marked as outdated.

Sign in to view

trunk-io[bot]

This comment was marked as outdated.

Sign in to view

trunk-io[bot]

This comment was marked as outdated.

Sign in to view

jmank88
jmank88 commented Feb 3, 2026
View reviewed changes
core/services/workflows/engine.go
Copy link
Contributor Author

@jmank88 jmank88 Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1 doesn't need override support

jmank88
jmank88 commented Feb 3, 2026
View reviewed changes
core/services/workflows/v2/secrets.go
Org: s.workflowOrg,
Owner: s.workflowOwner,
Workflow: s.workflowName,
Workflow: s.workflowID,
Copy link
Contributor Author

@jmank88 jmank88 Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice that workflow was set to name.

@jmank88 jmank88 force-pushed the CRE-1707-limits-org-id branch 3 times, most recently from 169c78e to 7d7e2c0 Compare February 3, 2026 12:59
@jmank88 jmank88 force-pushed the CRE-1707-limits-org-id branch from 7d7e2c0 to 8290f29 Compare February 3, 2026 13:25
@cl-sonarqube-production
Copy link

cl-sonarqube-production bot commented Feb 3, 2026

Quality Gate passed Quality Gate passed

Issues
2 New issues
12 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trunk-io trunk-io[bot] trunk-io[bot] left review comments

@bolekk bolekk Awaiting requested review from bolekk

@jinhoonbang jinhoonbang Awaiting requested review from jinhoonbang

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jmank88