Skip to content

Conversation

@softwareengineerprogrammer
Copy link
Owner

@softwareengineerprogrammer softwareengineerprogrammer commented Jan 24, 2026

Description

  1. Fixes off-by-one error in UPPReservoir.py interpretation of reservoir output file - last line was being erroneously excluded (2d22360)
  2. Adds Reservoir Output Profile and Reservoir Output Profile Time Step parameters as an alternative method to pass user-provided profile (makes UPP reservoir model compatible with web interface)

Testing & Verification

  1. Unit tests added:
    1. example5b - equivalent to example5 using Reservoir Output Profile and Reservoir Output Profile Time Step (instead of Reservoir Output File Name)
    2. test_user_provided_profile_reservoir_output_profile
    3. test_user_provided_profile_reservoir_output_profile_extrapolation
  2. Unit tests updated:
    1. example5 results slightly changed by bug fix
  3. Manually tested various scenarios, including with and without redrilling
    1. image
    2. image

Change Checklist:

Observe the following checklist items if your change includes a new version (see versioning notes and version management docs).

Before merging:

  1. Add a CHANGELOG entry: 1ca1705

After merging:

  1. Push tag(s) to GitHub: git push origin refs/tags/vM.m.P
  2. Post a change announcement to the GEOPHIRES Change Announcements Discussion (example). Markdown template:
M.m.p: [TITLE](https://github.com/NREL/GEOPHIRES-X/pull/PR-NUMBER) | [release](https://github.com/NREL/GEOPHIRES-X/releases/tag/vM.m.P)

Self-review: github.com//pull/129

…rofile parameter value - WIP to update test_user_provided_profile_reservoir_output_profile to ensure results match exactly (currently fails due to mismatch probably caused by off-by-one error somewhere...)
…_provided_profile_reservoir_output_profile now passes with exact dict equality
@softwareengineerprogrammer softwareengineerprogrammer added bug Something isn't working enhancement New feature or request labels Jan 24, 2026
@softwareengineerprogrammer softwareengineerprogrammer changed the title User Provided Reservoir Output Profile Fixes/Updates [v3.11.7] User Provided Reservoir Output Profile Fixes/Updates Jan 26, 2026
@softwareengineerprogrammer softwareengineerprogrammer changed the title [v3.11.7] User Provided Reservoir Output Profile Fixes/Updates [v3.11.8] User Provided Reservoir Output Profile Fixes/Updates Jan 26, 2026
@softwareengineerprogrammer softwareengineerprogrammer changed the title [v3.11.8] User Provided Reservoir Output Profile Fixes/Updates [v3.11.8] User-Provided Reservoir Output Profile Fix & Reservoir Output Profile Parameter Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants