forked from NatLabRockies/GEOPHIRES-X
-
Notifications
You must be signed in to change notification settings - Fork 1
[v3.11.8] User-Provided Reservoir Output Profile Fix & Reservoir Output Profile Parameter #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
softwareengineerprogrammer
wants to merge
29
commits into
main
Choose a base branch
from
user-provided-reservoir-output-profile-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[v3.11.8] User-Provided Reservoir Output Profile Fix & Reservoir Output Profile Parameter #129
softwareengineerprogrammer
wants to merge
29
commits into
main
from
user-provided-reservoir-output-profile-2
+939
−243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5b should have better parity with example5)
…text file and profile parameter
… - TODO to clean up commented code)
…rofile parameter value - WIP to update test_user_provided_profile_reservoir_output_profile to ensure results match exactly (currently fails due to mismatch probably caused by off-by-one error somewhere...)
…_provided_profile_reservoir_output_profile now passes with exact dict equality
…ally apply to other examples
…not already in the input file
…DO to verify logic and write unit tests, etc.
…SAM+Economic+Models+do+not+calculate+carbon+revenue in SAM-EM Limitations section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reservoir Output ProfileandReservoir Output Profile Time Stepparameters as an alternative method to pass user-provided profile (makes UPP reservoir model compatible with web interface)Testing & Verification
example5b- equivalent toexample5usingReservoir Output ProfileandReservoir Output Profile Time Step(instead ofReservoir Output File Name)test_user_provided_profile_reservoir_output_profiletest_user_provided_profile_reservoir_output_profile_extrapolationexample5results slightly changed by bug fixChange Checklist:
Observe the following checklist items if your change includes a new version (see versioning notes and version management docs).
Before merging:
After merging:
git push origin refs/tags/vM.m.PSelf-review: github.com//pull/129