Fix car charging manual SOC reset to zero on entity write #3284
+109
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual car SOC (
input_number.predbat_car_charging_manual_soc_kwh) was being reset to zero during charging slots. Root causes: entity configured withrestore: Falsecausing HA restart resets, and no validation before writing predicted values back to entity.Changes
State persistence (
config.py)restore: Trueforcar_charging_manual_soc_kwhentities (all 4 cars)Write protection (
predbat.py)car_charging_soc_nextbefore updating entityDiagnostic logging (
fetch.py)Tests (
tests/test_car_charging_manual_soc.py)Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.octopus.energy/home/REDACTED/work/batpred/batpred/coverage/venv/bin/python3 python3 ../apps/predbat/unit_test.py --quick(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.