-
Notifications
You must be signed in to change notification settings - Fork 0
ROX-325150: Use Kubearchive for getting snapshots for the release #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ROX-325150: Use Kubearchive for getting snapshots for the release #304
Conversation
scripts/generate-releases.sh
Outdated
| snapshot_copy_name="$(echo "${snapshot%-*}-${release_name_suffix}" | cut -c -63)" # Replace random suffix with release name and crop to 63 characters to avoid running over the Kubernetes limit. | ||
| echo "---" | ||
| kubectl -n rh-acs-tenant get snapshot.appstudio.redhat.com "${snapshot}" -o yaml | \ | ||
| kubectl ka -n rh-acs-tenant get snapshot.appstudio.redhat.com "${snapshot}" -o yaml | \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to generate releases on the 0d6c22807f4629bf5aa5a065c7607bace38b7458 (current HEAD of the PR branch) and got an empty yaml:
./scripts/generate-releases.sh stage
---
apiVersion: null
kind: null
metadata:
labels: null
name: acs-operator-index-ocp-v4-12-20260120-stage-0d6c228
namespace: null
spec: nullI believe this is because this command will also return a list (with exactly one entry).
I am on this version:
$ kubectl ka version
kubectl-archive version v1.16.0
Build date: 2025-12-15T10:55:03Z
Git commit: 2032dac903c738150efa554158d642afecb6d22c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this. There was a bug indeed and kubearchive has a different format when fetching snapshots as YAML. It's fixed and I added testing release to the PR description
Co-authored-by: Tom Martensen <tmartens@redhat.com>
tommartensen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a nit and a discussion
Co-authored-by: Tom Martensen <tmartens@redhat.com>
…-release' of https://github.com/stackrox/operator-index into akurlov/ROX-325150-use-kubearchive-to-get-snapshots-for-release
|
/retest operator-index-ocp-v4-20-on-push |
Unfortunately snapshots might be getting deleted really fast on Konflux (in 1 hour or even faster). But the release process requires those snapshots. So it is more robust to rely on kubearchive to fetch snapshots instead.
Tested:
And the output: