SD-1525 - comment export with empty array #1790
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84a978b339
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@mattConnHarbour looking good just a small comment + tests
packages/super-editor/src/core/super-converter/v2/exporter/commentsExporter.js
Outdated
Show resolved
Hide resolved
…587) (#1806) * fix: remove dead code * refactor: table and paragraph converters to avoid redirection * test: adjust existing tests * fix: remove unused imports and dead code * fix: pass theme colors to node handlers * refactor: simplify type definitions for converters --------- Co-authored-by: Luccas Correa <luccas@superdoc.dev>
mattConnHarbour
force-pushed
the
SD-1525
branch
3 times, most recently
from
fbece02 to
7dfbad0
Compare
…false, with tests
mattConnHarbour
force-pushed
the
SD-1525
branch
from
7dfbad0 to
f28852b
Compare
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
just 2 minor things - should be good after that
| ); | ||
|
|
||
| // Update content types and comments files as needed | ||
| // Empty array preserves existing comments unless preserveCommentsOnEmpty is true |
There was a problem hiding this comment.
Comment is backwards.
Says "unless preserveCommentsOnEmpty is true" but should be "false".
true = preserve
false = remove
|
|
||
| // Update content types and comments files as needed | ||
| // Empty array preserves existing comments unless preserveCommentsOnEmpty is true | ||
| let updatedXml = { ...this.convertedXml }; |
There was a problem hiding this comment.
let updatedXml = { ...this.convertedXml } is immediately overwritten on line 1031
example: