fix: use stable comment ids for imported comments #1863
Merged
+91
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
luccas-harbour
commented
Jan 28, 2026
luccas-harbour
commented
- SD used to generate a different UUID as a comment's internal id every time a document was imported.
- This PR changes that so that it uses a hash of the comment's imported id and its date for imported comments so that they are stable.
luccas-harbour
force-pushed
the
luccas/sd-1672-bug-generate-stable-ids-for-imported-comments
branch
from
c6dce2b to
b14d227
Compare
caio-pizzol
requested changes
Jan 28, 2026
packages/super-editor/src/core/super-converter/v2/importer/documentCommentsImporter.js
Outdated
Show resolved
Hide resolved
packages/super-editor/src/core/super-converter/v2/importer/documentCommentsImporter.js
Outdated
Show resolved
Hide resolved
packages/super-editor/src/tests/import/documentCommentsImporter.unit.test.js
Outdated
Show resolved
Hide resolved
harbournick
deleted the
luccas/sd-1672-bug-generate-stable-ids-for-imported-comments
branch
harbournick
pushed a commit
that referenced
this pull request
Jan 29, 2026
## [1.9.1-next.1](v1.9.0...v1.9.1-next.1) (2026-01-29) ### Bug Fixes * **comments:** pass superdoc instance when canceling pending comment ([#1862](#1862)) ([4982bac](4982bac)) * selection/caret issues ([#1865](#1865)) ([3f627fb](3f627fb)) * use stable comment ids for imported comments ([#1863](#1863)) ([0c330d0](0c330d0))
Collaborator
|
🎉 This PR is included in version 1.9.1-next.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.