fix: incorrect list counter calculation (SD-1658) #1867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luccas-harbour
force-pushed
the
luccas/sd-1658-bug-list-items-at-same-level-with-same-indicator-render-as
branch
from
42b9929 to
a538fe7
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a538fe784c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
packages/super-editor/src/core/helpers/list-numbering-helpers.js
Outdated
Show resolved
Hide resolved
packages/super-editor/src/extensions/paragraph/NumberingManager.js
Outdated
Show resolved
Hide resolved
added 4 commits
January 28, 2026 14:01
The modified version of the numbering manager was modified in the v1 release and incorrectly tracked numbering counters by num id instead of abstract num id. This commit also implements Word's behavior where a counter will restart if the level's startOverride was set.
luccas-harbour
force-pushed
the
luccas/sd-1658-bug-list-items-at-same-level-with-same-indicator-render-as
branch
from
a538fe7 to
c27cc50
Compare
…with-same-indicator-render-as
harbournick
deleted the
luccas/sd-1658-bug-list-items-at-same-level-with-same-indicator-render-as
branch
Collaborator
|
🎉 This PR is included in version 1.9.0-next.13 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
harbournick
pushed a commit
that referenced
this pull request
Jan 29, 2026
# [1.9.0](v1.8.3...v1.9.0) (2026-01-29) ### Bug Fixes * add typesVersions for TypeScript subpath exports ([#1851](#1851)) ([923ab29](923ab29)) * annotation and interaction issues ([#1847](#1847)) ([ffb1055](ffb1055)) * annotation formatting ([0ac67b2](0ac67b2)) * apply correct style to inserted links ([#1871](#1871)) ([36e3c4b](36e3c4b)) * block ID collisions and missing positions in paragraph converter ([3e75a98](3e75a98)) * correct cursor position when typing after fully track-deleted content ([#1828](#1828)) ([8de1c5f](8de1c5f)) * **export:** prefix Relationship IDs with rId for valid xsd:ID ([#1855](#1855)) ([11e67e1](11e67e1)) * incorrect list counter calculation (SD-1658) ([#1867](#1867)) ([a960a65](a960a65)) * list numbering sync for cloned defs and zero start overrides ([c21301b](c21301b)) * make test:slow script find the slow test file ([5a6b6d6](5a6b6d6)) * patch broken numbering definitions ([#1848](#1848)) ([f34b121](f34b121)) * preserve style on row insertion ([#1553](#1553)) ([92f67dc](92f67dc)) * preserve text selection on right-click in Firefox ([#1826](#1826)) ([0a23338](0a23338)) * remove redundant parameters in pm-adapter (SD-1587) ([#1823](#1823)) ([e315ad4](e315ad4)) * table resize ([#1821](#1821)) ([e7e1eb8](e7e1eb8)) * text in new paragraph doesn't inherit styles (SD-1657) ([#1869](#1869)) ([275fef2](275fef2)) ### Features * dev collab mode ([#1860](#1860)) ([469477b](469477b)) * fix node types export, add introspection ([#1815](#1815)) ([9b8d0d4](9b8d0d4))
Collaborator
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packages/word-layoutbut it's never called from anywhere else except the numbering plugin. The file was moved back to the same module as the numbering plugin.startOverrideproperty set, even if a list item with the sameabstractNumIdhas already been seen. This behavior was implemented.