Skip to content

Conversation

@luccas-harbour
Copy link
Contributor

  • Fixes an issue where text added to a new paragraph would not inherit inline run properties from the previous paragraph.
  • After investigating Word's behavior, logic was implemented so that the properties from the last run in the preceding paragraph are always copied over to the new run
  • Also, making formatting changes to the first run in the paragraph now also impacts the paragraph's paragraphProperties.runProperties. Those properties are used for styling list markers and now we have the same behavior as Word.

@linear
Copy link

linear bot commented Jan 28, 2026

@luccas-harbour luccas-harbour force-pushed the luccas/sd-1657-bug-text-in-new-paragraph-doesnt-inherit-styles branch from 1d68ee0 to 894c7d1 Compare January 28, 2026 18:50
@luccas-harbour luccas-harbour force-pushed the luccas/sd-1657-bug-text-in-new-paragraph-doesnt-inherit-styles branch from 894c7d1 to d524c7f Compare January 28, 2026 19:08
@luccas-harbour luccas-harbour marked this pull request as ready for review January 28, 2026 19:16
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d524c7f701

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

When a new run is added as the first child of an empty paragraph, it
should copy the same inline run properties as the last run in the
paragraph that precedes it (if there is one).
@luccas-harbour luccas-harbour force-pushed the luccas/sd-1657-bug-text-in-new-paragraph-doesnt-inherit-styles branch from d524c7f to 0732e8c Compare January 28, 2026 19:25
Copy link
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harbournick harbournick merged commit 275fef2 into main Jan 28, 2026
4 of 5 checks passed
@harbournick harbournick deleted the luccas/sd-1657-bug-text-in-new-paragraph-doesnt-inherit-styles branch January 28, 2026 23:29
harbournick pushed a commit that referenced this pull request Jan 28, 2026
# [1.9.0-next.12](v1.9.0-next.11...v1.9.0-next.12) (2026-01-28)

### Bug Fixes

* text in new paragraph doesn't inherit styles (SD-1657) ([#1869](#1869)) ([275fef2](275fef2))
@harbournick
Copy link
Collaborator

🎉 This PR is included in version 1.9.0-next.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

harbournick pushed a commit that referenced this pull request Jan 29, 2026
# [1.9.0](v1.8.3...v1.9.0) (2026-01-29)

### Bug Fixes

* add typesVersions for TypeScript subpath exports ([#1851](#1851)) ([923ab29](923ab29))
* annotation and interaction issues ([#1847](#1847)) ([ffb1055](ffb1055))
* annotation formatting ([0ac67b2](0ac67b2))
* apply correct style to inserted links ([#1871](#1871)) ([36e3c4b](36e3c4b))
* block ID collisions and missing positions in paragraph converter ([3e75a98](3e75a98))
* correct cursor position when typing after fully track-deleted content ([#1828](#1828)) ([8de1c5f](8de1c5f))
* **export:** prefix Relationship IDs with rId for valid xsd:ID ([#1855](#1855)) ([11e67e1](11e67e1))
* incorrect list counter calculation (SD-1658) ([#1867](#1867)) ([a960a65](a960a65))
* list numbering sync for cloned defs and zero start overrides ([c21301b](c21301b))
* make test:slow script find the slow test file ([5a6b6d6](5a6b6d6))
* patch broken numbering definitions ([#1848](#1848)) ([f34b121](f34b121))
* preserve style on row insertion ([#1553](#1553)) ([92f67dc](92f67dc))
* preserve text selection on right-click in Firefox ([#1826](#1826)) ([0a23338](0a23338))
* remove redundant parameters in pm-adapter (SD-1587) ([#1823](#1823)) ([e315ad4](e315ad4))
* table resize ([#1821](#1821)) ([e7e1eb8](e7e1eb8))
* text in new paragraph doesn't inherit styles (SD-1657) ([#1869](#1869)) ([275fef2](275fef2))

### Features

* dev collab mode ([#1860](#1860)) ([469477b](469477b))
* fix node types export, add introspection ([#1815](#1815)) ([9b8d0d4](9b8d0d4))
@harbournick
Copy link
Collaborator

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants