SD-511 - fix: comments not being restored on "undo" #1872
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 755e8969af
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| commentsList.value.forEach((comment) => { | ||
| const key = getCommentPositionKey(comment); | ||
| if (!key) return; | ||
|
|
||
| const hasActiveAnchor = activeKeys.has(String(key)); | ||
| if (hasActiveAnchor && comment.resolvedTime) { | ||
| clearResolvedMetadata(comment); |
There was a problem hiding this comment.
In syncResolvedCommentsWithDocument you clear resolvedTime for any comment whose ID appears in editorCommentPositions (lines 140-146). However, editorCommentPositions is also populated for tracked-change marks (see comments-plugin.js, where tracked changes call updatePosition with their id), and those marks are not removed when a tracked-change comment is resolved. This means resolving a tracked-change thread will be reverted as soon as positions are recalculated (e.g., on scroll/selection updates), so tracked-change comments can’t stay resolved. Consider skipping comment.trackedChange or otherwise limiting this sync to real comment anchors only.
Useful? React with 👍 / 👎.
No description provided.