-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade freeRASP SDK to latest versions [17.0.0 on Android & 6.13.0 on iOS] #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…llbacks (onMultiInstance, onUnsecureWiFi, onTimeSpoofing, onLocationSpoofing)
martinzigrai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The start method now requires a new parameter: TalsecMode.
You can find an example/reference here: https://github.com/talsec/Free-RASP-ReactNative/blob/3672228776c1c4cdf43b568d883182938e47d585/android/src/main/java/com/freeraspreactnative/FreeraspReactNativeModule.kt#L75
I also suggest including the flavor-specific .xcframework directly as a release attachment. @tompsota can tell you where to find the specific .xcframework.
| compileOnly files('libs/unity-classes.jar') | ||
| // freeRASP SDK | ||
| implementation 'com.aheaditec.talsec.security:TalsecSecurity-Community:15.1.0' | ||
| implementation 'com.aheaditec.talsec.security:TalsecSecurity-Community:17.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plugin import is using the incorrect flavor. Could you please change it to com.aheaditec.talsec.security:TalsecSecurity-Community-Unity:17.0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tompsota Where can i find flavor-specific .xcframework ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. I have updated the Android dependency to
com.aheaditec.talsec.security:TalsecSecurity-Community-Unity:17.0.1
& for iOS. The framework is added by the developer after they export their project to xcode. We have this section in the document that guides them (see link below). Hence, we need to update the link so it points to the unreal flavour
https://docs.talsec.app/freerasp/integration/unity?utm_source=github#add-freerasp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I have updated this PR title to indicate we are integrating v6.13.0 for iOS SDK
| @Override | ||
| public void onLocationSpoofingDetected() { | ||
| UnityPlayer.UnitySendMessage(this.gameObjectName, "scanResult", "onLocationSpoofing"); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upgrade to SDK 17 should also include the new onAllChecksFinished callback (from RaspExecutionState). This is currently missing from the implementation.
For refference:
- https://github.com/talsec/Free-RASP-ReactNative/blob/master/android/src/main/java/com/freeraspreactnative/events/RaspExecutionStateEvent.kt
- https://github.com/talsec/Free-RASP-ReactNative/blob/3672228776c1c4cdf43b568d883182938e47d585/android/src/main/java/com/freeraspreactnative/FreeraspThreatHandler.kt#L92
| break; | ||
| case "onLocationSpoofing": | ||
| this.threatDetectedCallback.onLocationSpoofing(); | ||
| break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plugins/iOS/NativeBridge.swift
Outdated
| case .screenRecording: | ||
| message = "screenRecording" | ||
| case .timeSpoofing: | ||
| message = "onTimeSpoofing" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…oofing for ios was added v6.14.0
Here is high level summary of changes
build.gradle(com.aheaditec.talsec.security:TalsecSecurity-Community:17.0.0)Controller.javaNativeBridge.swiftTalsec.csupdated to handle the new calls from number 2 & 3 abovePending