Remove usage of auto-setup and gitpod #447
Conversation
|
We should also remove references to Docker in the search attributes sample. Anyway, it's no longer true that ES is required for that. |
| The fastest way to try out these samples is running them in the browser: | ||
|
|
||
| - Gitpod: [One click to try](https://gitpod.io/#https://github.com/temporalio/samples-typescript/) (there is a good free tier) | ||
| - [GitHub Codespaces](https://docs.github.com/en/codespaces/developing-in-codespaces/creating-a-codespace#creating-a-codespace) (if your org admin has enabled this) - [90 second video demo](https://youtu.be/FdEQQC9EdfU) |
There was a problem hiding this comment.
Is GH codespaces supposed to be removed as well?
There was a problem hiding this comment.
That should still be possible, but I personally have no strong feeling in explicitly calling this out.
mjameswh
left a comment
mjameswh
left a comment
There was a problem hiding this comment.
One reference left, but otherwise lgtm
Aside from the README, I think the only remaining docker reference is in |
I wasn't, but now that you mention it, there's indeed no reason for a custom But my point was about the SA's README.md file, which should no longer need to mention docker or ElasticSearch. |
What was changed
Removed usage of the
auto-setupimage and gitpod.Why?
auto-setupis deprecated, gitpod is no longer used.