[TRUNK-17384] Change default for errors to not give failure code #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes our default behaviour on errors to be to continue with quarantining and returning error codes based on test status, with carveouts for the cases where we believe an error is a result of user misconfiguration: - The server is sending any of the error codes it uses when your org slug and token disagree - We tried to find a git repo and couldn't find it - You told us to error out if there weren't any test reports, and there weren't any Creates the InterruptingError as a carveout for when we explicitly want to errors to block the user. As part of this, discovered that our integration tests that use the mock server were misconfigured - any response in a handler other than the expected response message would actually get sent to the cli as a 516 invalid media type. The fix for this was to pull the handler from a closure to a fn so we could define the return type as Response<Body>, at which point the into_response function axum uses can actually return it.
cmillar-trunk
requested review from
TylerJang27,
acatxnamedvirtue,
max-trunk and
mb1206
as code owners
|
Merging to
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #990 +/- ##
==========================================
+ Coverage 80.72% 81.01% +0.29%
==========================================
Files 66 66
Lines 14178 14235 +57
==========================================
+ Hits 11445 11533 +88
+ Misses 2733 2702 -31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes our default behaviour on errors to be to continue with quarantining and returning error codes based on test status, with carveouts for the cases where we believe an error is a result of user misconfiguration:
As part of this, discovered that our integration tests that use the mock server were misconfigured - any response in a handler other than the expected response message would actually get sent to the cli as a 516 invalid media type. The fix for this was to pull the handler from a closure to a fn so we could define the return type as Response, at which point the into_response function axum uses can actually return it.