-
Notifications
You must be signed in to change notification settings - Fork 37
336 cran warning futilelogger set to be archived #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check if passes with earlier version of igraph bloop igraph to latest
ef76638 to
fc72b4f
Compare
This reverts commit 8027d42.
289c084 to
ad24829
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the
futile.loggerdependency with a custom base R logging class (resolves #336). This is necessary to maintain Pkgnet on CRAN. Thank you past contributors for making this one straightforward via the wrapper on the logger (blame view shows @jameslamb )!In the process, I also configured this project to be able to leverage Claude Code for quick assistance.
Changes Made
0: Configure Repo for Claude Code
CLAUDE.mdat root1. Created Custom Logger Class
File:
R/logging.RSimpleLoggerR6 class using only base R functions (message(),warning(),stop()).get_logger()2. Maintained Wrapper Functions
File:
R/logging.Rlog_info()- logs informational messageslog_warn()- logs warnings and triggers Rwarning()log_fatal()- logs fatal errors and triggers Rstop()silence_logger()- sets threshold to 0 (silent)unsilence_logger()- sets threshold to 4 (INFO level)3. Created Comprehensive Unit Tests
File:
tests/testthat/test-logging.RSimpleLoggerclass functionality4. Updated Test Setup/Teardown
tests/testthat/setup-logger.Rto use new loggertests/testthat/teardown-logger.Rto use new logger5. Removed futile.logger Dependency
DESCRIPTIONImports section.github/workflows/smoke-tests.yamlworkflowWhat Was NOT Changed
log_info/log_warn/log_fatalcalls throughout the codebase remain unchanged (though they now use the new logger). Thanks contributors for foresight on this one!Outcome
The implementation maintains backward compatibility with all existing logging calls while removing the external dependency. All tests pass.