Make clusterGroup.isHubCluster optional #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dminnear-rh
reviewed
Jan 16, 2026
dminnear-rh
reviewed
Jan 16, 2026
mbaldessari
force-pushed
the
ishubcluster
branch
from
c581e01 to
f4c1057
Compare
We can figure out if a node is the hub or not by omparing global.localClusterDomain and global.hubClusterDomain. If those are the same we're on the hub, if they are not we're not on the hub. Keep supporting the clusterGroup.isHubCluster variable with precedence in order to not break any existing pattern. Tested on 4.19 and 4.20 with mcg hub/spoke
mbaldessari
force-pushed
the
ishubcluster
branch
from
f4c1057 to
b938324
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can figure out if a node is the hub or not by omparing
global.localClusterDomain and global.hubClusterDomain. If those are the
same we're on the hub, if they are not we're not on the hub.
Keep supporting the clusterGroup.isHubCluster variable with precedence
in order to not break any existing pattern.
Tested on 4.19 and 4.20 with mcg hub/spoke