Under annotations #245
Under annotations #245
Conversation
|
|
||
| switch (handlerResult) { | ||
| case ({ } /* dummy */, { } atoms): // Atoms producer (pre-styled) | ||
| case ( { } /* dummy */, { } atoms): // Atoms producer (pre-styled) |
There was a problem hiding this comment.
I don't think auto-formatting made this. It's unnecessary spacing which isn't symmetrical with the right side.
There was a problem hiding this comment.
Idk, I didn't it manually for sure, I'm using VS code. Btw any objections with the generic name UnderAnnotation ? same gonna do later as OverAnnotation for Overbrace, Overbracket... If any better suggestion, better to suggest it now.
There was a problem hiding this comment.
I don't have particular opinions on the naming. Are they extensions of Underline and Overline? Maybe they can be merged together too.
There was a problem hiding this comment.
Abstract category naming UnderAnnotation = abstraction for \underbrace, \underbracket, \underbrace ... only Nucleus is identifier.
There was a problem hiding this comment.
You have two \underbrace in your comment. Did you mean to put \underline there?
There was a problem hiding this comment.
An alternative name may be "Under" which is similar to the existing "Inner" atom. This name would be even more appropriate if the existing Underline is also made to use this.
Though I also see that an underline may not correspond to a text Nucleus directly.
| case (null, null): // Atom modifier | ||
| continue; | ||
| case ({ } resultAtom, null): // Atom producer | ||
| case ( { } resultAtom, null): // Atom producer |
|
@Happypig375 Implementation might take a few days, especially display part is a quite complicated, on a Mathify I've spent more then week :) I'll do a small commits, please track all my commits for better quality and quick fixes. |
|
@Happypig375 Just ran the dotnet format command on a core CSharpMath.csproj , and it broght changes on 53 files, similar to what it changed that you commented already. Lats first resolve problem with autoformatting. I'm using vs code ide, which ide do you use and which formatters? don't want to bring lots of formatting changes on my pr 
|
|
@hflexgrig I just use Visual Studio and it formats things on the fly. You can pull request all the auto formatting. The unnecessary space should be fixed though. |
…rpMath into under_annotations
2 participants
Here in this pr I'll try to bring under annotations ( \underbrace, \underbracket ) with display and latex support