Skip to content

trying to measure the overhead of VortexMetrics #6029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AdamGS wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

trying to measure the overhead of VortexMetrics #6029

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
949ac8f
trying to measure the overhead of VortexMetrics
AdamGS Jan 19, 2026
af930b1
Merge branch 'develop' into adamg/metrics-overhead
AdamGS Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions vortex-file/src/open.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ use vortex_dtype::DType;
use vortex_error::VortexError;
use vortex_error::VortexExpect;
use vortex_error::VortexResult;
use vortex_io::InstrumentedReadAt;
use vortex_io::VortexReadAt;
use vortex_io::session::RuntimeSessionExt;
use vortex_layout::segments::NoOpSegmentCache;
Expand Down Expand Up @@ -165,7 +164,8 @@ impl VortexOpenOptions {
///
/// This is a low-level API and we strongly recommend using [`VortexOpenOptions::open`].
async fn open_read<R: VortexReadAt>(self, read: R) -> VortexResult<VortexFile> {
let read = Arc::new(InstrumentedReadAt::new(Arc::new(read), &self.metrics));
let read = Arc::new(read);
// let read = Arc::new(InstrumentedReadAt::new(Arc::new(read), &self.metrics));

let footer = if let Some(footer) = self.footer {
footer
Expand Down
Loading