Skip to content

Conversation

@caicancai
Copy link
Contributor

@caicancai caicancai commented Jan 19, 2026

The VortexReadAt::concurrency() function of ByteBuffer has a fixed concurrency of 16, which cannot be overridden by the caller. Users' in-memory data sources may require lower/higher concurrency to control scheduling overhead.

We could provide a default value of 16 while allowing users to explicitly set the concurrency.

Signed-off-by: cancaicai <2356672992@qq.com>
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 56.41026% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.90%. Comparing base (b7a7027) to head (c2b6c6a).
⚠️ Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-io/src/read.rs 56.41% 17 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@caicancai
Copy link
Contributor Author

caicancai commented Jan 20, 2026

@joseph-isaacs Hello. Since it's a minor change, I submitted a pull request directly. If it's not suitable, I can close the pull request.
But I'm curious why the fixed configuration is 16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant