-
Notifications
You must be signed in to change notification settings - Fork 3
build(deps-dev): Bump @wordpress/eslint-plugin from 22.22.0 to 24.0.0 #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps-dev): Bump @wordpress/eslint-plugin from 22.22.0 to 24.0.0 #286
Conversation
899894f to
bc74bb0
Compare
Bumps [@wordpress/eslint-plugin](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin) from 22.22.0 to 24.0.0. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/eslint-plugin@24.0.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@wordpress/eslint-plugin" dependency-version: 24.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
`@wordpress` modules are no longer excluded from the `import/no-extraneous-dependencies` rule. See: WordPress/gutenberg#72978
Address lint errors following recent changes to the `@wordpress/eslint-plugin` package. Align with the Gutenberg project. See: WordPress/gutenberg#72978 ``` ./GutenbergKit/src/utils/wordpress-globals.js 47:41 error Unable to resolve path to module '@wordpress/preferences-persistence' import/no-unresolved ```
bc74bb0 to
28c69cf
Compare
Regeneration is required after upgrading package versions.
```
**ERROR** Failed to apply patch for package @wordpress/rich-text at path
node_modules/@wordpress/rich-text
This error was caused because @wordpress/rich-text has changed since you
made the patch file for it. This introduced conflicts with your patch,
just like a merge conflict in Git when separate incompatible changes are
made to the same piece of code.
Maybe this means your patch file is no longer necessary, in which case
hooray! Just delete it!
Otherwise, you need to generate a new patch file.
To generate a new one, just repeat the steps you made to generate the first
one.
i.e. manually make the appropriate file changes, then run
patch-package @wordpress/rich-text
Info:
Patch file: patches/@WordPress+rich-text+7.37.0.patch
Patch was made for version: 7.37.0
Installed version: 7.38.0
```
| settings: { | ||
| 'import/resolver': { | ||
| node: { | ||
| // Matches file extensions supported by WordPress build tools | ||
| // See: https://github.com/WordPress/gutenberg/blob/760acec3522516c2212e0213ff10cd2a8c9e8df0/tools/eslint/import-resolver.js#L15 | ||
| extensions: [ '.js', '.jsx', '.mjs', '.cjs' ], | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address lint errors following recent changes to the
@wordpress/eslint-plugin package. Align with the Gutenberg project.
See: WordPress/gutenberg#72978
./GutenbergKit/src/utils/wordpress-globals.js
47:41 error Unable to resolve path to module '@wordpress/preferences-persistence' import/no-unresolved
| "test:unit:watch": "vitest" | ||
| }, | ||
| "dependencies": { | ||
| "@wordpress/a11y": "^4.36.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wordpress modules are no longer excluded from the import/no-extraneous-dependencies rule. Therefore, we must explicitly declare these dependencies that we export as window globals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regenerated this existing patch file for the new package version.
|
Very confused as to why auto-merge proceeded while the CI checks failed. I'll follow up with a fix. |
|
Addressed in #290. |
Bumps @wordpress/eslint-plugin from 22.22.0 to 24.0.0.
Changelog
Sourced from
@wordpress/eslint-plugin's changelog.Commits
50c4c0fchore(release): publish28afca3Update changelog files0022c1fMerge changes published in the Gutenberg plugin "release/22.4" branch2cf13ecchore(release): publishd096bedUpdate changelog filesef20cbfMerge changes published in the Gutenberg plugin "release/22.3" branchDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)