-
Notifications
You must be signed in to change notification settings - Fork 76
Add ProofreadPage quality support and cover all Model #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #551 +/- ##
============================================
+ Coverage 71.30% 74.57% +3.26%
- Complexity 1275 1411 +136
============================================
Files 46 45 -1
Lines 3792 4323 +531
============================================
+ Hits 2704 3224 +520
- Misses 1088 1099 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Phew, now mergeable with main. The changes in the last few months mean we're not at 100% model anymore; I'll try and put Model & Helper (& maybe Repository &/| EventSuscriber) to 100%. It's only 46 (not counting repo & events) lines to cover. |
In common
(Sorry if I use WS jargon, feel free to ask.)
EditCounter
PagesCreated
page_propswithpp_propname = "proofread_page_quality_level"TopEdits
getTopEditsAllNamespaces. Change from a 3-level query with custom row numbering with assignments and a random join at the end for the title (?) to a 2-level query with the built-inROW_NUMBER(the one that caused trouble when it reserved the name recently).page_propslike in PCDon't make a chart, though, because it implies being done over all the data and we can't do that for TopEdits (I think?). At any rate, right now all we do is count 'em; whereas for PC we already make some other stats.
Tests
I'm also adding many, many tests. That has led me to refactorise some code, fix a few bugs here and there, make a few private methods public, etc. Feel free to ask for the reason behind specific changes. Goal would be 100% on model and some other stuff.
Bug: T173012