Skip to content

Conversation

@antoinegaston
Copy link

@antoinegaston antoinegaston commented Jan 16, 2026

This PR fixes this issue relativizing paths for ObjectStore.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.md
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jan 16, 2026
@antoinegaston antoinegaston reopened this Jan 16, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 16, 2026

Merging this PR will not alter performance

✅ 30 untouched benchmarks


Comparing antoinegaston:fix-obstore-listdir (ef19e83) with main (e94504e)

Open in CodSpeed

@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.86%. Comparing base (4cddcf5) to head (89dbb6e).

Files with missing lines Patch % Lines
src/zarr/storage/_obstore.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3657      +/-   ##
==========================================
- Coverage   60.88%   60.86%   -0.03%     
==========================================
  Files          86       86              
  Lines       10182    10184       +2     
==========================================
- Hits         6199     6198       -1     
- Misses       3983     3986       +3     
Files with missing lines Coverage Δ
src/zarr/testing/store.py 75.00% <100.00%> (ø)
src/zarr/storage/_obstore.py 59.81% <50.00%> (-1.02%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zarr+obstore directory listing truncates names (likely str.lstrip bug), breaks AnnData/Zarr reads on Azure

2 participants