Dev 0.1.12 #64

lachlangrose · 2026-01-14T23:59:46Z

No description provided.

Bumps [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact) from 9 to 11. - [Release notes](https://github.com/dawidd6/action-download-artifact/releases) - [Commits](dawidd6/action-download-artifact@v9...v11) --- updated-dependencies: - dependency-name: dawidd6/action-download-artifact dependency-version: '11' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

ci: fix formatting of release-please

…ction-download-artifact-11 Bump dawidd6/action-download-artifact from 9 to 11

…processing/sorter

adding basal contacts unit name

#59) * Initial plan * feat: add debug manager and directory setting Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com> * chore: refine debug handling and options Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com> * chore: address review follow ups Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com> * fix: convert unit_name_field to 'UNITNAME' * fix: updating unload to prevent error when missing dock widgets * fix: rename unit_name_column to unit_name_field * fix: update stratigraphic column with calculated thicknesses * fix: update stratigraphic unit to prevent missing widget error * style: formatting * chore: log layer sources in debug params Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com> * feat: export layers and add offline runner script Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com> * fix: give debug manager the logger * fix: add generic exporter for m2l objects * fix: pass debug manager to api for exporting packages * move export to debug manager --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com> Co-authored-by: Lachlan Grose <lachlan.grose@monash.edu>

* Initial plan * feat: add debug manager and directory setting Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com> * chore: refine debug handling and options Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com> * chore: address review follow ups Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com> * fix: convert unit_name_field to 'UNITNAME' * fix: updating unload to prevent error when missing dock widgets * fix: rename unit_name_column to unit_name_field * fix: update stratigraphic column with calculated thicknesses * fix: update stratigraphic unit to prevent missing widget error * style: formatting * chore: log layer sources in debug params Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com> * feat: export layers and add offline runner script Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com> * fix: give debug manager the logger * fix: add generic exporter for m2l objects * fix: pass debug manager to api for exporting packages * move export to debug manager * adding rebuild with debounce when geometry properties are changed * call update feature when rebuild is required * adding progress bar when model update is required * keep track of source feature for meshes * update feature in viewer when it changes * fix: debug mode changes logging * adding copilot fixes --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

…into dev-0.1.12

Copilot

Pull request overview

This pull request represents development release 0.1.12, introducing significant enhancements to the LoopStructural QGIS plugin. The PR adds map2loop integration tools, improves performance through debouncing and threading, implements an Observable pattern for model updates, and includes extensive code cleanup.

Changes:

Added map2loop processing tools (sampler, sorter, basal contacts, thickness calculator) with dedicated GUI widgets and API integration
Implemented Observer pattern for model updates with background threading support for expensive operations
Added intelligent column matching utility (ColumnMatcher) and debug infrastructure for troubleshooting
Enhanced UI responsiveness with debounced rebuilds and efficient stratigraphic column updates
Updated dependencies (LoopStructural 1.6.24, numpy 1.26.4) and cleaned up code formatting

Reviewed changes

Copilot reviewed 49 out of 72 changed files in this pull request and generated 56 comments.

Show a summary per file

File	Description
loopstructural/main/m2l_api.py	New API module providing unified interface to map2loop tools (sampling, sorting, contacts, thickness)
loopstructural/main/helpers.py	Column matching utility with fuzzy string matching and geological field aliases
loopstructural/main/model_manager.py	Observable pattern implementation with thread-safe notifications and update methods
loopstructural/plugin_main.py	Duplicate action/menu registrations; defensive unload logic
loopstructural/gui/map2loop_tools/*.py	New GUI widgets for map2loop processing tools
loopstructural/gui/modelling/geological_model_tab/*.py	Background threading for model updates; debounced feature rebuilds
loopstructural/toolbelt/preferences.py	Debug directory preference and logging configuration
loopstructural/requirements.txt	Dependency updates (LoopStructural 1.6.24, numpy 1.26.4)
tests/qgis/*.py	Whitespace cleanup and string formatting improvements
tests/qgis/test_column_matching.py	Comprehensive test suite for ColumnMatcher

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-19T00:22:12Z

loopstructural/main/m2l_api.py

+    # Build units DataFrame
+    if (
+        unit_name_field
+        and unit_name_field != unit_name_field


Comparison of identical values; use cmath.isnan() if testing for not-a-number.

Copilot · 2026-01-19T00:22:13Z

loopstructural/main/m2l_api.py

+    try:
+        if debug_manager and getattr(debug_manager, "is_debug", lambda: False)():
+
+            _layers = {"geology": geology, "faults": faults}


Variable _layers is not used.

Copilot · 2026-01-19T00:22:13Z

loopstructural/main/m2l_api.py

+        if debug_manager and getattr(debug_manager, "is_debug", lambda: False)():
+
+            _layers = {"geology": geology, "faults": faults}
+            _pickles = {"contact_extractor": contact_extractor}


Variable _pickles is not used.

Copilot · 2026-01-19T00:22:13Z

loopstructural/main/m2l_api.py

+            _layers = {"geology": geology, "faults": faults}
+            _pickles = {"contact_extractor": contact_extractor}
+            # export layers and pickles first to get the actual filenames used
+            _exported = export_debug_package(


Variable _exported is not used.

Copilot · 2026-01-19T00:22:13Z

loopstructural/main/m2l_api.py

+    try:
+        if debug_manager and getattr(debug_manager, "is_debug", lambda: False)():
+
+            _exported = export_debug_package(


Variable _exported is not used.

Copilot · 2026-01-19T00:22:24Z

loopstructural/main/vectorLayerWrapper.py

+                epsg = geodataframe.crs.to_epsg()
+                if epsg:
+                    crs = QgsCoordinateReferenceSystem.fromEpsgId(int(epsg))
+            except Exception:


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2026-01-19T00:22:24Z

loopstructural/main/vectorLayerWrapper.py

+            if isinstance(val, np.generic):
+                try:
+                    val = val.item()
+                except Exception:


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2026-01-19T00:22:24Z

loopstructural/gui/visualisation/feature_list_widget.py

+                    logger.debug(f"Removed existing mesh: {mesh_name}")
+                except Exception:
+                    logger.debug(f"Failed to remove existing mesh: {mesh_name}")
+                    pass


Unnecessary 'pass' statement.

Copilot · 2026-01-19T00:22:24Z

loopstructural/gui/modelling/geological_model_tab/feature_details_panel.py

+            self._rebuild_timer.start()
+        except Exception:
+            logger.debug('Failed to schedule debounced rebuild', exc_info=True)
+            pass


Unnecessary 'pass' statement.

Suggested change

pass

Copilot · 2026-01-19T00:22:25Z

loopstructural/main/m2l_api.py

+    except Exception as e:
+        print("Failed to save sampler debug info")
+        print(e)
+        pass


Unnecessary 'pass' statement.

lachlangrose and others added 30 commits June 17, 2025 10:43

initial commit

bf3c7c2

adding pyproject.toml for ruff

ef6deba

change linter to ruff

bfd0a9c

adding release please action

70aafd5

linting

a330933

ci: fix formatting of release-please

0122b59

Merge pull request #2 from Loop3D/main

1a5e7b7

ci: fix formatting of release-please

Update linter.yml

90ebef3

Update release-please.yml

ec42a79

fixing syntax

d85b581

adding release please files

8ad1c4e

Merge pull request #1 from Loop3D/dependabot/github_actions/dawidd6/a…

387086f

…ction-download-artifact-11 Bump dawidd6/action-download-artifact from 9 to 11

fix: import typo

6ae8d3f

Merge branch 'main' of github.com:Loop3D/plugin_map2loop

7bf312d

template for basal contacts processing tool

c0bb5f2

Update linter.yml

f9878b0

disable qgis testing for now

b51f758

Update release-please.yml

b3fc47d

Update release-please.yml

56a20ae

Merge remote-tracking branch 'origin/processing/basal_contacts' into …

043ea5c

…processing/sorter

feature: Implement StratigraphySorterAlgorithm

773ef48

feature: functions to convert layers to GeoDataFrame and DataFrame

e7bb9f6

feature: add geodataframe to qgsLayer conversion

95ba89b

refactor: update GeoDataFrameToQgsLayer

f744d83

fix: GeoDataFrameToQgsLayer to FeatureSink

ea67c2e

refactor: clean up imports in vectorLayerWrapper.py

f11d713

feature: add basal contacts extraction algorithm

d718b96

refactor: add imports in sorter.py

0c7e768

feature: implement sampler algorithm

aeed68b

lachlangrose and others added 15 commits December 16, 2025 11:08

fix: update strat column thickness after thickness calc

9c6d4a9

fix: connect up thickness calc

01dfbd4

fix: store location tracking and lines for thickness calculators

06e586f

adding basal contacts unit name

style: ruff check --fix

3a37ae0

style: ruff check

dc726d8

Merge branch 'main' into copilot/create-separate-gui-components

19d5070

fix: incorrect field name

70fdbbb

fix: convert unit_name_field to 'UNITNAME'

351a96a

fix: updating unload to prevent error when missing dock widgets

2ec3fcd

fix: rename unit_name_column to unit_name_field

24cc539

fix: update stratigraphic column with calculated thicknesses

56ceb77

fix: update stratigraphic unit to prevent missing widget error

5fba7c8

style: formatting

4a0ba19

lachlangrose added UI quality tooling labels Jan 14, 2026

lachlangrose added 4 commits January 15, 2026 17:04

Merge branch 'dev-0.1.12' of github.com:Loop3D/plugin_loopstructural …

f995ffc

…into dev-0.1.12

ci: updating pre-commit yaml

bb9cbf0

style: pre-commit/ruff

ddd955c

style: ruff

d197176

lachlangrose added documentation Improvements or additions to documentation ci-cd labels Jan 15, 2026

lachlangrose added 2 commits January 15, 2026 17:16

fix: add topology calculator widget

c7d9b8e

fix: bump loopstructural version

dea0075

lachlangrose mentioned this pull request Jan 18, 2026

Add map2loop processing tool dialogs accessible from plugin menu #54

Closed

lachlangrose requested a review from Copilot January 19, 2026 00:15

Copilot started reviewing on behalf of lachlangrose January 19, 2026 00:16 View session

Copilot AI reviewed Jan 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Dev 0.1.12 #64

Dev 0.1.12 #64

lachlangrose commented Jan 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 19, 2026

Uh oh!

Copilot AI Jan 19, 2026

Uh oh!

Copilot AI Jan 19, 2026

Uh oh!

Copilot AI Jan 19, 2026

Uh oh!

Copilot AI Jan 19, 2026

Uh oh!

Copilot AI Jan 19, 2026

Uh oh!

Copilot AI Jan 19, 2026

Uh oh!

Copilot AI Jan 19, 2026

Uh oh!

Copilot AI Jan 19, 2026

Uh oh!

Copilot AI Jan 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Dev 0.1.12 #64

Are you sure you want to change the base?

Dev 0.1.12 #64

Conversation

lachlangrose commented Jan 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants