Fix for recent engine syncs #7
Closed
+20
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
reviewed
Jan 24, 2026
| endfunction() | ||
|
|
||
| build_hl2sdk(CS2 hl2sdk-cs2) | ||
| build_hl2sdk(DOTA hl2sdk-deadlock) |
Member
There was a problem hiding this comment.
i dont think this file needs to be changed anymore since its specified in build_game, although the dota needs to be fixed to be dota.
Collaborator
There was a problem hiding this comment.
yea this overrides how the sdk projects are configured, this is not to be touched
Collaborator
|
I haven't received a mail for this PR so I have just now independently made the same changes and already pushed those to master, the dota/deadlock switch I pushed from this PR. a3cb723 |
Contributor
Author
|
Whoops, sorry that it didn't notify you. At least I'm glad you noticed fixes for other games before attempting them yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've set every game to use CS2 SDK for now, as others haven't been updated yet. I was able to complete a dump for all games on my Windows machine, I also tried CS2 on a Linux server myself (although very minimal, since I didn't have all dependencies installed on it to load client libraries).
Some classInfos in schema can now be null in GlobalTypes apparently, but only a few from my experience. Maybe they are initialized as part of some other library that we just don't load here.