Skip to content

Fix for recent engine syncs #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LionDoge wants to merge 6 commits into from
+20 −23
Closed

Fix for recent engine syncs #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f4215cb
remove some no longer needed stubs, add null check in DumpClasses
LionDoge Jan 23, 2026
dc47434
update hl2sdk-cs2
LionDoge Jan 23, 2026
8f2049b
Add null check to enumInfo, warn if class/enum is null.
LionDoge Jan 23, 2026
51539a5
Switch all games to use CS2 sdk for now
LionDoge Jan 23, 2026
456dfc2
Add another exclusion to GetKV3Defaults (relevant to Deadlock)
LionDoge Jan 23, 2026
6e626fc
Add class/enum name to warnings if their info in schema is null.
LionDoge Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ function(BUILD_GAME GAME GAME_PATH SDK)
endfunction()

build_game(CS2 csgo CS2)
build_game(DOTA dota DOTA)
build_game(DEADLOCK citadel DEADLOCK)
build_game(DOTA dota CS2)
build_game(DEADLOCK citadel CS2)

source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR} PREFIX "Source Files" FILES ${SOURCES_LIST})
source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR} PREFIX "Header Files" FILES ${HEADERS_LIST})
1 change: 1 addition & 0 deletions src/main/dumpers/schemas/metadata_stringifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ std::unordered_set<std::string> g_classWithBrokenDefaults =
"Dop26_t",
"FourCovMatrices3",
"VMixVocoderDesc_t",
"CCitadelPlayerPawn_GraphController2"
};

// Any function called after this will have uninitialized variables set to zero
Expand Down
16 changes: 14 additions & 2 deletions src/main/dumpers/schemas/schemas.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,13 @@ void DumpClasses(CSchemaSystemTypeScope* typeScope, std::filesystem::path schema
{
FOR_EACH_MAP(typeScope->m_DeclaredClasses.m_Map, iter)
{
const auto classInfo = typeScope->m_DeclaredClasses.m_Map.Element(iter)->m_pClassInfo;
const auto schemaClass = typeScope->m_DeclaredClasses.m_Map.Element(iter);
const auto classInfo = schemaClass->m_pClassInfo;
if (!classInfo)
{
spdlog::warn("Null classInfo: {}::{}", typeScope->GetScopeName(), schemaClass->m_sTypeName.Get());
continue;
}

if (!std::filesystem::is_directory(schemaPath / classInfo->m_pszProjectName))
if (!std::filesystem::create_directory(schemaPath / classInfo->m_pszProjectName))
Expand Down Expand Up @@ -142,7 +148,13 @@ void DumpEnums(CSchemaSystemTypeScope* typeScope, std::filesystem::path schemaPa
{
FOR_EACH_MAP(typeScope->m_DeclaredEnums.m_Map, iter)
{
const auto enumInfo = typeScope->m_DeclaredEnums.m_Map.Element(iter)->m_pEnumInfo;
const auto schemaEnum = typeScope->m_DeclaredEnums.m_Map.Element(iter);
const auto enumInfo = schemaEnum->m_pEnumInfo;
if (!enumInfo)
{
spdlog::warn("Null enumInfo {}::{}", typeScope->GetScopeName(), schemaEnum->m_sTypeName.Get());
continue;
}

if (!std::filesystem::is_directory(schemaPath / enumInfo->m_pszProjectName))
if (!std::filesystem::create_directory(schemaPath / enumInfo->m_pszProjectName))
Expand Down
16 changes: 0 additions & 16 deletions src/main/utils/common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,6 @@ void ExitError(const char* pMsg, ...)

/* tier0 stub */

void CThreadSpinRWLock::LockForRead(const char* pFileName, int nLine)
{
// STUB
}

void CThreadSpinRWLock::UnlockRead(const char* pFileName, int nLine)
{
// STUB
}

LoggingResponse_t LoggingSystem_LogAssert(const char* pMessageFormat, ...)
{
return LR_ABORT;
Expand Down Expand Up @@ -81,15 +71,9 @@ void CUtlString::Trim(const char*) {
// STUB
}

#ifdef GAME_CS2
CUtlBuffer::CUtlBuffer(const void*, int, CUtlBuffer::BufferFlags_t) {
// STUB
}
#else
CUtlBuffer::CUtlBuffer(void const*, int, int) {
// STUB
}
#endif

void ConMsg(const char*, ...) {
// STUB
Expand Down
4 changes: 2 additions & 2 deletions vendor/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ function(BUILD_HL2SDK GAME GAME_PATH)
endfunction()

build_hl2sdk(CS2 hl2sdk-cs2)
build_hl2sdk(DOTA hl2sdk-deadlock)
Copy link
Member

@xPaw xPaw Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think this file needs to be changed anymore since its specified in build_game, although the dota needs to be fixed to be dota.

Copy link
Collaborator

@Poggicek Poggicek Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea this overrides how the sdk projects are configured, this is not to be touched

build_hl2sdk(DEADLOCK hl2sdk-deadlock)
build_hl2sdk(DOTA hl2sdk-cs2)
build_hl2sdk(DEADLOCK hl2sdk-cs2)

# EXTERNAL LIBRARIES
# ---
Expand Down
2 changes: 1 addition & 1 deletion vendor/hl2sdk-cs2
Open in desktop
Submodule hl2sdk-cs2 updated 52 files
+23 −112 common/netmessages.proto
+9 −0 common/networkbasetypes.proto
+124 −0 common/source2_steam_stats.proto
+2 −2 entity2/entitykeyvalues.cpp
+1 −1 game/shared/base_gcmessages.proto
+26 −0 game/shared/cs/cs_gameevents.proto
+1 −0 game/shared/cstrike15/cstrike15_gcmessages.proto
+4 −0 game/shared/cstrike15/cstrike15_usermessages.proto
+2 −0 game/shared/econ/econ_gcmessages.proto
+3 −0 game/shared/gameevents.proto
+42 −40 game/shared/gamesystems/spawngroup_manager.h
+39 −34 game/shared/igamesystem.h
+5 −0 game/shared/usercmd.proto
+4 −2 game/shared/usermessages.proto
+ − lib/linux64/libtier0.so
+ − lib/linux64/tier1.a
+ − lib/public/win64/tier0.lib
+ − lib/public/win64/tier1.lib
+3 −3 public/bitvec.h
+4 −14 public/const.h
+6 −16 public/edict.h
+23 −4 public/engine/IEngineService.h
+5 −0 public/entity2/entityclass.h
+12 −9 public/entity2/entityinstance.h
+2 −2 public/entity2/entitykeyvalues.h
+5 −5 public/entity2/entitysystem.h
+4 −1 public/gametrace.h
+5 −0 public/globalvars_base.h
+5 −1 public/icvar.h
+0 −1 public/iloopmode.h
+2 −0 public/irecipientfilter.h
+15 −9 public/iserver.h
+1 −1 public/localize/ilocalize.h
+17 −3 public/networkstringtabledefs.h
+8 −13 public/playerslot.h
+8 −2 public/schemasystem/schemasystem.h
+2 −2 public/tier0/logging.h
+3 −3 public/tier0/platform.h
+69 −461 public/tier0/threadtools.h
+11 −11 public/tier1/bitbuf.h
+18 −1 public/tier1/convar.h
+35 −35 public/tier1/keyvalues3.h
+1 −1 public/tier1/mempool.h
+12 −2 public/tier1/utlblockmemory.h
+1 −1 public/tier1/utlhashtable.h
+2 −2 public/tier1/utllinkedlist.h
+1 −1 public/tier1/utlmemory.h
+1 −1 public/tier1/utlrbtree.h
+2 −2 public/tier1/utlsymbollarge.h
+2 −2 public/tier1/utlvector.h
+28 −28 tier1/bitbuf.cpp
+21 −19 tier1/keyvalues3.cpp
Loading