-
Notifications
You must be signed in to change notification settings - Fork 3
renovate: Add 1 week minimumReleaseAge for dependency updates #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @cgwalters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modifies the Renovate configuration to implement a strategy for managing dependency updates more efficiently. By introducing a default waiting period, it aims to significantly reduce the volume of pull requests generated by rapidly updating dependencies, thereby decreasing development team overhead and improving overall stability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a minimumReleaseAge of one week for all dependencies to reduce noise from frequent updates, which is a great improvement for stability and reducing churn. It also correctly adds an exception for bcvk packages to allow immediate updates. I've added one suggestion to make the package matching pattern for the exception more specific to prevent potential future conflicts.
renovate-shared-config.json
Outdated
| // such as our own projects or critical dependencies. | ||
| { | ||
| "description": ["Pick up bcvk packages immediately without waiting"], | ||
| "matchPackagePatterns": ["bcvk"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current pattern ["bcvk"] will match any package name containing "bcvk" as a substring, which could unintentionally match unrelated packages. To make this rule more specific and prevent future issues, it's better to anchor the pattern to match only at the beginning of the package name.
If your packages are named like bcvk-cli, the suggested pattern ^bcvk is more precise. If they are scoped like @bcvk/core, you should use ^@bcvk/.
| "matchPackagePatterns": ["bcvk"], | |
| "matchPackagePatterns": ["^bcvk"], |
|
Looks like the validation is failing because |
b33618d to
b760809
Compare
gursewak1997
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need -s in commit command but lgtm
Reduce PR noise from rapidly-updating dependencies by waiting 1 week before proposing updates. Analysis showed some packages (e.g., opencode-ai) had 7 updates in 8 days, creating excessive churn. Exceptions can be added for packages that should bypass the waiting period, such as our own projects (bcvk) or critical dependencies. Assisted-by: OpenCode (Claude Sonnet 4) Signed-off-by: Colin Walters <walters@verbum.org>
b760809 to
8deec11
Compare
Reduce PR noise from rapidly-updating dependencies by waiting 1 week before proposing updates. Analysis showed some packages (e.g., opencode-ai) had 7 updates in 8 days, creating excessive churn.
Exceptions can be added for packages that should bypass the waiting period, such as our own projects (bcvk) or critical dependencies.
Assisted-by: OpenCode (Claude Sonnet 4)