fix(android): use absolute keystore path for android.injected.signing… #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….store.file When sign=true, the build failed with: Keystore file '/home/runner/.gradle/daemon/9.0.0/release.keystore' not found for signing config 'externalOverride'. It seems like the action wrote only the filename (e.g. release.keystore) to android.injected.signing.store.file. AGP treats it as a path and resolves relative values from the Gradle daemon directory, so it looked in the wrong place. My Solution: - Run "Create local gradle.properties" after "Decode and store keystore" so KEYSTORE_TARGET_PATH (absolute path) is available. - Set android.injected.signing.store.file=$KEYSTORE_TARGET_PATH instead of the bare filename. AGP's externalOverride then finds the keystore. ROCK_UPLOAD_* and other signing properties are unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
….store.file
When sign=true, the build failed with:
It seems like the action wrote only the filename (e.g. release.keystore) to android.injected.signing.store.file. AGP treats it as a path and resolves relative values from the Gradle daemon directory, so it looked in the wrong place.
My Solution:
ROCK_UPLOAD_* and other signing properties are unchanged.