Skip to content

fix(android): use absolute keystore path for android.injected.signing… #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 1 commit into from
Jan 20, 2026
Merged

fix(android): use absolute keystore path for android.injected.signing… #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,25 +182,6 @@ runs:
if: ${{ inputs.validate-gradle-wrapper == 'true' && !env.ARTIFACT_URL }}
uses: gradle/actions/wrapper-validation@ac638b010cf58a27ee6c972d7336334ccaf61c96 # v4.4.1

- name: Create local gradle.properties
if: ${{ !env.ARTIFACT_URL && inputs.sign }}
run: |
mkdir -p $HOME/.gradle
touch $HOME/.gradle/gradle.properties

# Android standard properties (auto-recognized by AGP)
echo "android.injected.signing.store.file=${{ inputs.keystore-store-file }}" >> $HOME/.gradle/gradle.properties
echo "android.injected.signing.store.password=${{ inputs.keystore-store-password }}" >> $HOME/.gradle/gradle.properties
echo "android.injected.signing.key.alias=${{ inputs.keystore-key-alias }}" >> $HOME/.gradle/gradle.properties
echo "android.injected.signing.key.password=${{ inputs.keystore-key-password }}" >> $HOME/.gradle/gradle.properties

# Rock custom properties (for apps that explicitly read them in signingConfigs)
echo "ROCK_UPLOAD_STORE_FILE=${{ inputs.keystore-store-file }}" >> $HOME/.gradle/gradle.properties
echo "ROCK_UPLOAD_STORE_PASSWORD=${{ inputs.keystore-store-password }}" >> $HOME/.gradle/gradle.properties
echo "ROCK_UPLOAD_KEY_ALIAS=${{ inputs.keystore-key-alias }}" >> $HOME/.gradle/gradle.properties
echo "ROCK_UPLOAD_KEY_PASSWORD=${{ inputs.keystore-key-password }}" >> $HOME/.gradle/gradle.properties
shell: bash

- name: Determine Android sourceDir and appName
if: ${{ !env.ARTIFACT_URL || (env.ARTIFACT_URL && inputs.re-sign) }}
run: |
Expand Down Expand Up @@ -240,6 +221,25 @@ runs:
shell: bash
working-directory: ${{ inputs.working-directory }}

- name: Create local gradle.properties
if: ${{ !env.ARTIFACT_URL && inputs.sign }}
run: |
mkdir -p $HOME/.gradle
touch $HOME/.gradle/gradle.properties

# Android standard properties (auto-recognized by AGP).
echo "android.injected.signing.store.file=$KEYSTORE_TARGET_PATH" >> $HOME/.gradle/gradle.properties
echo "android.injected.signing.store.password=${{ inputs.keystore-store-password }}" >> $HOME/.gradle/gradle.properties
echo "android.injected.signing.key.alias=${{ inputs.keystore-key-alias }}" >> $HOME/.gradle/gradle.properties
echo "android.injected.signing.key.password=${{ inputs.keystore-key-password }}" >> $HOME/.gradle/gradle.properties

# Rock custom properties (for apps that explicitly read them in signingConfigs)
echo "ROCK_UPLOAD_STORE_FILE=${{ inputs.keystore-store-file }}" >> $HOME/.gradle/gradle.properties
echo "ROCK_UPLOAD_STORE_PASSWORD=${{ inputs.keystore-store-password }}" >> $HOME/.gradle/gradle.properties
echo "ROCK_UPLOAD_KEY_ALIAS=${{ inputs.keystore-key-alias }}" >> $HOME/.gradle/gradle.properties
echo "ROCK_UPLOAD_KEY_PASSWORD=${{ inputs.keystore-key-password }}" >> $HOME/.gradle/gradle.properties
shell: bash

- name: Build Android
if: ${{ !env.ARTIFACT_URL }}
run: |
Expand Down