fix: Time out Unknown status after 5 minutes
#693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regardless of `max_polling_time`, it makes no sense to keep polling for an `Unknown` status after more than 5 minutes. At that point the ingress message will have expired and will never be inducted. Without this, and with `ic-system-test-driver` agents recently defaulting to a `max_polling_time` of 3600 seconds, tests with a timeout of 3600 seconds will fail if an ingress message is lost (which tends to be triggered by intentional replica restarts).
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Jan 28, 2026
IMHO, if a test has to wait for one hour for a response to be produced, then it's not a very useful test. And regardless of that, one hour should not be the default for every single system test. This is intended as a fix for the significant flakiness experienced recently by `//rs/tests/message_routing:state_sync_malicious_chunk_test`. All the failures are timeouts. And the last relevant message before the test times out is `Checking for subnet progress...`. After which, the test proceeds to make a canister call that never completes and is never retried (because the test expires before the call, after 3600 seconds). The other half of the fix (dfinity/agent-rs#693, which will have to wait for an `ic-agent` release) is to bail out if the status is still `Unknown` after 5 minutes, regardless of the configured `max_polling_time`.
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Jan 28, 2026
IMHO, if a test has to wait for one hour for a response to be produced, then it's not a very useful test. And regardless of that, one hour should not be the default for every single system test. This is intended as a fix for the significant flakiness experienced recently by `//rs/tests/message_routing:state_sync_malicious_chunk_test`. All the failures are timeouts. And the last relevant message before the test times out is `Checking for subnet progress...`. After which, the test proceeds to make a canister call that never completes and is never retried (because the test expires before the call, after 3600 seconds). The other half of the fix (dfinity/agent-rs#693, which will have to wait for an `ic-agent` release) is to bail out if the status is still `Unknown` after 5 minutes, regardless of the configured `max_polling_time`.
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Jan 28, 2026
IMHO, if a test has to wait for one hour for a response to be produced, then it's not a very useful test. And regardless of that, one hour should not be the default for every single system test. This is intended as a fix for the significant flakiness experienced recently by `//rs/tests/message_routing:state_sync_malicious_chunk_test`. All the failures are timeouts. And the last relevant message before the test times out is `Checking for subnet progress...`. After which, the test proceeds to make a canister call that never completes and is never retried (because the test expires before the call, after 3600 seconds). The other half of the fix (dfinity/agent-rs#693, which will have to wait for an `ic-agent` release) is to bail out if the status is still `Unknown` after 5 minutes, regardless of the configured `max_polling_time`.
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Jan 28, 2026
IMHO, if a test has to wait for one hour for a response to be produced, then it's not a very useful test. And regardless of that, one hour should not be the default for every single system test. This is intended as a fix for the significant flakiness experienced recently by `//rs/tests/message_routing:state_sync_malicious_chunk_test`. All the failures are timeouts. And the last relevant message before the test times out is `Checking for subnet progress...`. After which, the test proceeds to make a canister call that never completes and is never retried (because the test expires before the call, after 3600 seconds). The other half of the fix (dfinity/agent-rs#693, which will have to wait for an `ic-agent` release) is to bail out if the status is still `Unknown` after 5 minutes, regardless of the configured `max_polling_time`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regardless of
max_polling_time, it makes no sense to keep polling for anUnknownstatus after more than 5 minutes. At that point the ingress message will have expired and will never be inducted.Without this, and with
ic-system-test-driveragents recently defaulting to amax_polling_timeof 3600 seconds, tests with a timeout of 3600 seconds will fail if an ingress message is lost (which tends to be triggered by intentional replica restarts).Checklist: