-
Notifications
You must be signed in to change notification settings - Fork 5
RPC Rework: Part 1: Switching to .create
#1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Greptile OverviewGreptile SummaryRefactored the blueprint creation API to use a more object-oriented Key Changes:
This is a clean refactoring that improves API consistency and encapsulation without changing functionality. All usages across the codebase have been properly updated. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Module
participant ModuleBlueprintSet
participant ModuleBlueprint
participant TypeSystem
User->>Module: Access Module.blueprint property
Module->>ModuleBlueprintSet: Call ModuleBlueprintSet.create(Module, *args, **kwargs)
ModuleBlueprintSet->>ModuleBlueprint: Call ModuleBlueprint.create(Module, args, kwargs)
ModuleBlueprint->>TypeSystem: get_type_hints(module)
TypeSystem-->>ModuleBlueprint: Return type annotations
alt Type hints success
ModuleBlueprint->>ModuleBlueprint: Extract In/Out connections from annotations
else Type hints failed
ModuleBlueprint->>Module: Iterate module.__mro__ for __annotations__
Module-->>ModuleBlueprint: Return raw annotations
ModuleBlueprint->>ModuleBlueprint: Extract In/Out connections from raw annotations
end
ModuleBlueprint->>ModuleBlueprint: Build list of ModuleConnection objects
ModuleBlueprint-->>ModuleBlueprintSet: Return ModuleBlueprint instance
ModuleBlueprintSet-->>Module: Return ModuleBlueprintSet with single blueprint
Module-->>User: Return partial(ModuleBlueprintSet.create, Module)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No files reviewed, no comments
No description provided.