-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Security upgrade @backstage/types from 0.0.0-use.local to 0.1.1 #10751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-14908844 - https://snyk.io/vuln/SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291 - https://snyk.io/vuln/SNYK-JS-LODASH-15053838 - https://snyk.io/vuln/SNYK-JS-LODASHES-15053836 - https://snyk.io/vuln/SNYK-JS-DIFF-14917201
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security posture by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
WalkthroughThis pull request updates the dependency management for the Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant PM as Package Manager
participant Workspace as Local Workspace
participant Registry as NPM Registry
participant CoreAPI as @backstage/core-plugin-api
Note over Dev,Registry: Before: workspace:^ dependency
Dev->>PM: Build/Install dependencies
PM->>Workspace: Resolve @backstage/types (workspace:^)
Workspace-->>PM: Return local package
PM->>CoreAPI: Link local @backstage/types
Note over Dev,Registry: After: 0.1.1 dependency (This PR)
Dev->>PM: Build/Install dependencies
PM->>Registry: Fetch @backstage/types@0.1.1
Registry-->>PM: Return published package v0.1.1
PM->>CoreAPI: Install @backstage/types@0.1.1
Note over CoreAPI: Now uses published version<br/>instead of workspace reference
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, incorrectly downgrades the @backstage/types package. It changes the version from workspace:^, which resolves to the current workspace version (1.1.0), to a hardcoded 0.1.1. This is a significant downgrade that will likely cause issues. The workspace: protocol is the standard and correct way to reference other packages within this monorepo.
This change should be rejected. The reported vulnerabilities should be addressed manually, for example by running yarn upgrade for the affected transitive dependencies and updating the yarn.lock file.
Additionally, I've noticed that other dependencies in this package.json like @backstage/config and @backstage/version-bridge are also pinned to outdated versions, which is inconsistent with the project's changelog. It would be beneficial to investigate this and potentially update them to use workspace:^ as well to ensure consistency and correctness across the monorepo.
| "dependencies": { | ||
| "@backstage/config": "0.1.1", | ||
| "@backstage/types": "workspace:^", | ||
| "@backstage/types": "0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change incorrectly downgrades @backstage/types to version 0.1.1. The workspace:^ specifier correctly resolves to version 1.1.0 of the package from within this monorepo, as can be seen in packages/types/package.json. Hardcoding an old version is incorrect and will likely cause problems. This should be reverted to use the workspace protocol to ensure the correct version is used.
| "@backstage/types": "0.1.1", | |
| "@backstage/types": "workspace:^", |
Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
packages/core-plugin-api/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
SNYK-JS-ELLIPTIC-14908844
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
SNYK-JS-LODASH-15053838
SNYK-JS-LODASHES-15053836
SNYK-JS-DIFF-14917201
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution
EntelligenceAI PR Summary
This PR standardizes dependency management by replacing a workspace protocol reference with a fixed version for the
@backstage/typespackage.@backstage/typesdependency fromworkspace:^to version0.1.1packages/core-plugin-api/package.json