Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core-plugin-api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
},
"dependencies": {
"@backstage/config": "0.1.1",
"@backstage/types": "workspace:^",
"@backstage/types": "0.1.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly downgrades @backstage/types to version 0.1.1. The workspace:^ specifier correctly resolves to version 1.1.0 of the package from within this monorepo, as can be seen in packages/types/package.json. Hardcoding an old version is incorrect and will likely cause problems. This should be reverted to use the workspace protocol to ensure the correct version is used.

Suggested change
"@backstage/types": "0.1.1",
"@backstage/types": "workspace:^",

"@backstage/version-bridge": "0.1.0",
"@types/react": "^16.13.1 || ^17.0.0",
"history": "^5.0.0",
Expand Down
Loading