-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 6 vulnerabilities #10752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-14908844 - https://snyk.io/vuln/SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291 - https://snyk.io/vuln/SNYK-JS-LODASH-15053838 - https://snyk.io/vuln/SNYK-JS-LODASHES-15053836 - https://snyk.io/vuln/SNYK-JS-DIFF-14917201
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, addresses six security vulnerabilities by updating specific Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
⛔ Snyk checks have failed. 1 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, attempts to fix 6 vulnerabilities by updating dependencies in plugins/azure-sites/package.json. However, the proposed changes pin several @backstage packages to very old versions instead of using the workspace:^ protocol appropriate for this monorepo. This will likely break the application due to version mismatches and API incompatibilities. Furthermore, the PR description notes that yarn.lock could not be updated, confirming that these changes introduce dependency resolution issues. I have recommended rejecting these changes and instead using Yarn's resolutions feature to address the underlying transitive dependency vulnerabilities without breaking the project's structure.
| "@backstage/core-components": "0.1.0", | ||
| "@backstage/core-plugin-api": "workspace:^", | ||
| "@backstage/plugin-azure-sites-common": "workspace:^", | ||
| "@backstage/plugin-catalog-react": "workspace:^", | ||
| "@backstage/plugin-azure-sites-common": "0.1.0", | ||
| "@backstage/plugin-catalog-react": "0.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These version changes from workspace:^ to fixed, very old versions are likely to break the application. In a monorepo setup like this, packages are expected to use the versions from the current workspace. Pinning to old versions can lead to API incompatibilities and other issues.
For example:
@backstage/core-componentsis pinned to0.1.0, but the workspace version is0.13.4-next.0.@backstage/plugin-catalog-reactis pinned to0.0.1, but the workspace version is1.8.1-next.0.
Instead of pinning these direct dependencies, consider using Yarn's resolutions feature in the root package.json to force newer, non-vulnerable versions of the transitive dependencies that Snyk has flagged. This will fix the security issues without breaking the internal dependencies of the monorepo.
The PR description also notes that yarn.lock failed to update, which is a strong indication that these changes introduce dependency conflicts. It's best to revert these changes and address the vulnerabilities via resolutions.
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-azure-sites-common": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^"
WalkthroughThis PR updates the dependency management strategy for the azure-sites plugin by transitioning from workspace protocol references to explicit version pinning. Three Backstage packages are affected: Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant PM as Package Manager
participant Registry as NPM Registry
Note over Dev,Registry: Dependency Version Update Process
Dev->>PM: Update package.json dependencies
Note right of Dev: Change workspace:^ to<br/>specific versions
PM->>Registry: Resolve @backstage/core-components@0.1.0
Registry-->>PM: Return package metadata
PM->>Registry: Resolve @backstage/plugin-azure-sites-common@0.1.0
Registry-->>PM: Return package metadata
PM->>Registry: Resolve @backstage/plugin-catalog-react@0.0.1
Registry-->>PM: Return package metadata
PM->>PM: Update lock file
PM-->>Dev: Dependencies resolved
Note over Dev,Registry: No runtime behavior changes<br/>Only dependency version pinning
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/azure-sites/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
SNYK-JS-ELLIPTIC-14908844
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
SNYK-JS-LODASH-15053838
SNYK-JS-LODASHES-15053836
SNYK-JS-DIFF-14917201
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution
EntelligenceAI PR Summary
This PR transitions the azure-sites plugin from workspace protocol dependencies to explicit version pinning for three Backstage packages.
@backstage/core-componentsfrom workspace protocol to fixed version0.1.0@backstage/plugin-azure-sites-commonfrom workspace protocol to fixed version0.1.0@backstage/plugin-catalog-reactfrom workspace protocol to fixed version0.0.1