Skip to content

[Snyk] Fix for 6 vulnerabilities #10752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 6 vulnerabilities #10752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/azure-sites/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-azure-sites-common": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-azure-sites-common": "0.1.0",
"@backstage/plugin-catalog-react": "0.0.1",
Comment on lines +36 to +39
Copy link

@gemini-code-assist gemini-code-assist bot Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These version changes from workspace:^ to fixed, very old versions are likely to break the application. In a monorepo setup like this, packages are expected to use the versions from the current workspace. Pinning to old versions can lead to API incompatibilities and other issues.

For example:

  • @backstage/core-components is pinned to 0.1.0, but the workspace version is 0.13.4-next.0.
  • @backstage/plugin-catalog-react is pinned to 0.0.1, but the workspace version is 1.8.1-next.0.

Instead of pinning these direct dependencies, consider using Yarn's resolutions feature in the root package.json to force newer, non-vulnerable versions of the transitive dependencies that Snyk has flagged. This will fix the security issues without breaking the internal dependencies of the monorepo.

The PR description also notes that yarn.lock failed to update, which is a strong indication that these changes introduce dependency conflicts. It's best to revert these changes and address the vulnerabilities via resolutions.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/plugin-azure-sites-common": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^"

"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading