-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 6 vulnerabilities #10762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-14908844 - https://snyk.io/vuln/SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291 - https://snyk.io/vuln/SNYK-JS-LODASH-15053838 - https://snyk.io/vuln/SNYK-JS-LODASHES-15053836 - https://snyk.io/vuln/SNYK-JS-DIFF-14917201
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, focuses on enhancing the project's security posture by updating key dependencies. The changes are concentrated in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to fix several vulnerabilities by updating dependencies. While the update to lodash seems correct, the changes to the @backstage/* packages are problematic. Pinning these dependencies to specific versions instead of using workspace:^ breaks the monorepo structure and could lead to using outdated or incorrect code, causing potential build failures or runtime bugs. Some of the pinned versions are significant downgrades from what is in the workspace. Furthermore, the PR description explicitly states that the yarn.lock file could not be updated, which is a critical issue that must be resolved before merging. I recommend rejecting these automated changes and manually addressing the vulnerabilities in a way that respects the project's monorepo architecture.
| "@backstage/backend-common": "0.25.0", | ||
| "@backstage/config": "0.1.1", | ||
| "@backstage/errors": "0.1.1", | ||
| "@backstage/types": "0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes from workspace:^ to pinned versions are incorrect for a monorepo setup. This breaks the linkage between packages within the workspace, which can lead to using outdated or incorrect versions of internal packages, causing bugs or build failures.
For example:
@backstage/configis being downgraded from1.0.8to0.1.1.@backstage/errorsis being downgraded from1.2.1to0.1.1.@backstage/typesis being downgraded from1.1.0to0.1.1.
Using workspace:^ ensures that you are always using the version of the package that is present in the current workspace. Snyk's automated fix seems to have misinterpreted the monorepo structure.
The correct approach is to keep the workspace:^ specifier and address the vulnerabilities by updating the underlying dependencies within the respective packages in this monorepo. The PR description also notes that yarn.lock failed to update, which is another indicator that these changes are problematic.
"@backstage/backend-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/types": "workspace:^"
WalkthroughThis PR updates the dependency management strategy for the backend-tasks package by transitioning from workspace protocol references to explicit version pinning. Four Backstage packages (backend-common, config, errors, and types) are now locked to specific versions instead of using workspace references. Additionally, the lodash dependency is upgraded from version 4.17.21 to 4.17.23, which addresses known security vulnerabilities. This change affects how dependencies are resolved and may impact the package publishing workflow, moving away from a monorepo workspace dependency pattern to a more traditional fixed versioning approach. Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant BT as backend-tasks Package
participant BC as @backstage/backend-common
participant CFG as @backstage/config
participant ERR as @backstage/errors
participant TYP as @backstage/types
participant LOD as lodash
Note over BT: Package.json Dependency Updates
BT->>BC: Update version: workspace:^ → 0.25.0
BT->>CFG: Update version: workspace:^ → 0.1.1
BT->>ERR: Update version: workspace:^ → 0.1.1
BT->>TYP: Update version: workspace:^ → 0.1.1
BT->>LOD: Update version: ^4.17.21 → ^4.17.23
Note over BT,LOD: No runtime behavior changes<br/>Only dependency version updates
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
packages/backend-tasks/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
SNYK-JS-ELLIPTIC-14908844
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
SNYK-JS-LODASH-15053838
SNYK-JS-LODASHES-15053836
SNYK-JS-DIFF-14917201
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution
EntelligenceAI PR Summary
This PR transitions backend-tasks package dependencies from workspace protocol to explicit version pinning and updates lodash for security.