Skip to content

Conversation

@q1blue
Copy link
Collaborator

@q1blue q1blue commented Jan 25, 2026

snyk-top-banner

Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • packages/backend-tasks/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Improper Handling of Unicode Encoding
SNYK-JS-TAR-15038581
  208  
medium severity Use of a Cryptographic Primitive with a Risky Implementation
SNYK-JS-ELLIPTIC-14908844
  146  
high severity UNIX Symbolic Link (Symlink) Following
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
  113  
medium severity Prototype Pollution
SNYK-JS-LODASH-15053838
  88  
medium severity Prototype Pollution
SNYK-JS-LODASHES-15053836
  88  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-DIFF-14917201
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution


EntelligenceAI PR Summary

This PR transitions backend-tasks package dependencies from workspace protocol to explicit version pinning and updates lodash for security.

  • Changed @backstage/backend-common from workspace reference to version 0.25.0
  • Changed @backstage/config from workspace reference to version 0.1.1
  • Changed @backstage/errors from workspace reference to version 0.1.1
  • Changed @backstage/types from workspace reference to version 0.1.1
  • Upgraded lodash from ^4.17.21 to ^4.17.23 for security patch
  • Shifts from monorepo workspace dependency strategy to fixed version pinning

@codesandbox
Copy link

codesandbox bot commented Jan 25, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, focuses on enhancing the project's security posture by updating key dependencies. The changes are concentrated in the packages/backend-tasks module, specifically targeting vulnerabilities found in its package.json dependencies. The primary goal is to mitigate various security risks, ranging from prototype pollution to denial-of-service attacks, by upgrading affected packages to more secure versions.

Highlights

  • Automated Security Fix: This pull request was automatically generated by Snyk to address 6 identified security vulnerabilities in the project's yarn dependencies.
  • Dependency Updates: The packages/backend-tasks/package.json file has been updated to upgrade several @backstage packages to specific versions (e.g., @backstage/backend-common to 0.25.0, @backstage/config to 0.1.1, @backstage/errors to 0.1.1, @backstage/types to 0.1.1) and lodash to ^4.17.23.
  • Vulnerabilities Addressed: The updates aim to fix issues including 'Improper Handling of Unicode Encoding' (tar), 'Use of a Cryptographic Primitive with a Risky Implementation' (elliptic), 'UNIX Symbolic Link (Symlink) Following' (backstage-backend-plugin-api), 'Prototype Pollution' (lodash and lodashes), and 'Regular Expression Denial of Service' (diff).
  • Manual Intervention Required: A warning indicates that the yarn.lock file failed to update automatically and requires manual intervention before merging, especially for projects utilizing Yarn's zero-installs feature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link

snyk-io bot commented Jan 25, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix several vulnerabilities by updating dependencies. While the update to lodash seems correct, the changes to the @backstage/* packages are problematic. Pinning these dependencies to specific versions instead of using workspace:^ breaks the monorepo structure and could lead to using outdated or incorrect code, causing potential build failures or runtime bugs. Some of the pinned versions are significant downgrades from what is in the workspace. Furthermore, the PR description explicitly states that the yarn.lock file could not be updated, which is a critical issue that must be resolved before merging. I recommend rejecting these automated changes and manually addressing the vulnerabilities in a way that respects the project's monorepo architecture.

Comment on lines +35 to +38
"@backstage/backend-common": "0.25.0",
"@backstage/config": "0.1.1",
"@backstage/errors": "0.1.1",
"@backstage/types": "0.1.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes from workspace:^ to pinned versions are incorrect for a monorepo setup. This breaks the linkage between packages within the workspace, which can lead to using outdated or incorrect versions of internal packages, causing bugs or build failures.

For example:

  • @backstage/config is being downgraded from 1.0.8 to 0.1.1.
  • @backstage/errors is being downgraded from 1.2.1 to 0.1.1.
  • @backstage/types is being downgraded from 1.1.0 to 0.1.1.

Using workspace:^ ensures that you are always using the version of the package that is present in the current workspace. Snyk's automated fix seems to have misinterpreted the monorepo structure.

The correct approach is to keep the workspace:^ specifier and address the vulnerabilities by updating the underlying dependencies within the respective packages in this monorepo. The PR description also notes that yarn.lock failed to update, which is another indicator that these changes are problematic.

    "@backstage/backend-common": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/types": "workspace:^"

@entelligence-ai-pr-reviews
Copy link

Walkthrough

This PR updates the dependency management strategy for the backend-tasks package by transitioning from workspace protocol references to explicit version pinning. Four Backstage packages (backend-common, config, errors, and types) are now locked to specific versions instead of using workspace references. Additionally, the lodash dependency is upgraded from version 4.17.21 to 4.17.23, which addresses known security vulnerabilities. This change affects how dependencies are resolved and may impact the package publishing workflow, moving away from a monorepo workspace dependency pattern to a more traditional fixed versioning approach.

Changes

File(s) Summary
packages/backend-tasks/package.json Replaced workspace protocol references with explicit version numbers for @backstage/backend-common (0.25.0), @backstage/config (0.1.1), @backstage/errors (0.1.1), and @backstage/types (0.1.1); upgraded lodash from ^4.17.21 to ^4.17.23 to address security vulnerabilities.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant BT as backend-tasks Package
    participant BC as @backstage/backend-common
    participant CFG as @backstage/config
    participant ERR as @backstage/errors
    participant TYP as @backstage/types
    participant LOD as lodash

    Note over BT: Package.json Dependency Updates
    BT->>BC: Update version: workspace:^ → 0.25.0
    BT->>CFG: Update version: workspace:^ → 0.1.1
    BT->>ERR: Update version: workspace:^ → 0.1.1
    BT->>TYP: Update version: workspace:^ → 0.1.1
    BT->>LOD: Update version: ^4.17.21 → ^4.17.23
    
    Note over BT,LOD: No runtime behavior changes<br/>Only dependency version updates
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants