Skip to content

[Snyk] Fix for 6 vulnerabilities #10762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 6 vulnerabilities #10762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/backend-tasks/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/backend-common": "0.25.0",
"@backstage/config": "0.1.1",
"@backstage/errors": "0.1.1",
"@backstage/types": "0.1.1",
Comment on lines +35 to +38
Copy link

@gemini-code-assist gemini-code-assist bot Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes from workspace:^ to pinned versions are incorrect for a monorepo setup. This breaks the linkage between packages within the workspace, which can lead to using outdated or incorrect versions of internal packages, causing bugs or build failures.

For example:

  • @backstage/config is being downgraded from 1.0.8 to 0.1.1.
  • @backstage/errors is being downgraded from 1.2.1 to 0.1.1.
  • @backstage/types is being downgraded from 1.1.0 to 0.1.1.

Using workspace:^ ensures that you are always using the version of the package that is present in the current workspace. Snyk's automated fix seems to have misinterpreted the monorepo structure.

The correct approach is to keep the workspace:^ specifier and address the vulnerabilities by updating the underlying dependencies within the respective packages in this monorepo. The PR description also notes that yarn.lock failed to update, which is another indicator that these changes are problematic.

    "@backstage/backend-common": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/types": "workspace:^"

"@types/luxon": "^3.0.0",
"cron": "^2.0.0",
"knex": "^2.0.0",
"lodash": "^4.17.21",
"lodash": "^4.17.23",
"luxon": "^3.0.0",
"uuid": "^8.0.0",
"winston": "^3.2.1",
Expand Down
Loading