Fix buffer overflow in LM transition model LoadRestart causing segfauIt #2606 #2707
+45
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcarruscag
reviewed
Jan 14, 2026
Member
pcarruscag
left a comment
pcarruscag
left a comment
There was a problem hiding this comment.
Please modify one of the LM tests to use a restart file.
Comment on lines
552
to
553
| * completes. Previously, this code incorrectly tried to read them from indices [index+2] and [index+3], | ||
| * which caused a buffer overflow since only nVar=2 solution variables are stored per point. ---*/ |
Member
There was a problem hiding this comment.
It's not necessary to document what was wrong before, just the present state is enough.
Suggested change
| * completes. Previously, this code incorrectly tried to read them from indices [index+2] and [index+3], | |
| * which caused a buffer overflow since only nVar=2 solution variables are stored per point. ---*/ | |
| * completes. ---*/ |
guptapratykshh
force-pushed
the
fix/lm-transition-model-adjoint-2606
branch
from
79ba3f8 to
e7b6a1f
Compare
pcarruscag
reviewed
Jan 16, 2026
TestCases/tutorials.py
Outdated
Comment on lines
240
to
242
| tutorial_trans_flatplate_T3A.test_vals = [-5.808996, -2.070606, -3.969765, -0.277943, -1.953093, 1.708472, -3.514943, 0.357411] | ||
| tutorial_trans_flatplate_T3A.test_vals_aarch64 = [-5.808996, -2.070606, -3.969765, -0.277943, -1.953289, 1.708472, -3.514943, 0.357411] | ||
| tutorial_trans_flatplate_T3A.no_restart = True | ||
| # Restart test enabled to verify LM transition model restart functionality (issue #2606) |
Member
There was a problem hiding this comment.
Is it suspicious that you get the same results after turning on the restart?
Contributor
Author
There was a problem hiding this comment.
actually, that is exactly what we want to see, the residuals picked up right where they left off instead of resetting, which confirms state loaded correctly
the tiny variation is just standard noise from recomputing derived fields, but fact that it runs stable
guptapratykshh
force-pushed
the
fix/lm-transition-model-adjoint-2606
branch
from
0d70a9b to
6023eee
Compare
pcarruscag
requested changes
Jan 16, 2026
TestCases/tutorials.py
Outdated
Comment on lines
240
to
242
| tutorial_trans_flatplate_T3A.test_vals = [-5.808996, -2.070606, -3.969765, -0.277943, -1.953093, 1.708472, -3.514943, 0.357411] | ||
| tutorial_trans_flatplate_T3A.test_vals_aarch64 = [-5.808996, -2.070606, -3.969765, -0.277943, -1.953289, 1.708472, -3.514943, 0.357411] | ||
| tutorial_trans_flatplate_T3A.no_restart = True | ||
| # Restart test enabled to verify LM transition model restart functionality (issue #2606) |
guptapratykshh
force-pushed
the
fix/lm-transition-model-adjoint-2606
branch
from
9e8d752 to
a2758c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixed buffer overflow in the Langtry-Menter model where derived variables were incorrectly read from the restart file, causing segmentation faults. This ensures the discrete adjoint solver runs correctly and simulations can be restarted without crashing.
Related Work
Resolves #2606.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.