Skip to content

Fix buffer overflow in LM transition model LoadRestart causing segfauIt #2606 #2707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guptapratykshh wants to merge 2 commits into
base: develop
Choose a base branch
from
+45 −2
Open

Fix buffer overflow in LM transition model LoadRestart causing segfauIt #2606 #2707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc1a3a0
Fix buffer overflow in LM transition model LoadRestart causing segfau…
guptapratykshh Jan 14, 2026
a2758c9
Fix LM transition model restart and add automated regression test #2606
guptapratykshh Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions SU2_CFD/src/solvers/CTransLMSolver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,8 +546,10 @@ void CTransLMSolver::LoadRestart(CGeometry** geometry, CSolver*** solver, CConfi

const auto index = counter * Restart_Vars[1] + skipVars;
for (auto iVar = 0u; iVar < nVar; iVar++) nodes->SetSolution(iPoint_Local, iVar, Restart_Data[index + iVar]);
nodes->SetIntermittencySep(iPoint_Local, Restart_Data[index + 2]);
nodes->SetIntermittencyEff(iPoint_Local, Restart_Data[index + 3]);

/*--- Note: Intermittency_Sep and Intermittency_Eff are derived variables computed in Postprocessing,
* not solution variables stored in the restart file. They will be recomputed after this function
* completes. ---*/

/*--- Increment the overall counter for how many points have been loaded. ---*/
counter++;
Expand Down
10 changes: 10 additions & 0 deletions TestCases/serial_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,16 @@ def main():
schubauer_klebanoff_transition.test_iter = 10
schubauer_klebanoff_transition.test_vals = [-8.284308, -13.239421, 0.000057, 0.007982]
test_list.append(schubauer_klebanoff_transition)

# LM Transition model restart
lm_transition_restart = TestCase('lm_transition_restart')
lm_transition_restart.cfg_dir = "transition/LM_NACA0012"
lm_transition_restart.cfg_file = "trans_LM_restart.cfg"
lm_transition_restart.test_iter = 4
lm_transition_restart.test_vals = [-1.654301, -5.151570, -2.075488, 0.000000, 0.000000]
lm_transition_restart.tol = 0.001
test_list.append(lm_transition_restart)


#####################################
### Cont. adj. compressible Euler ###
Expand Down
Binary file added TestCases/transition/LM_NACA0012/restart_flow.dat
View file
Open in desktop
Binary file not shown.
31 changes: 31 additions & 0 deletions TestCases/transition/LM_NACA0012/trans_LM_restart.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
SOLVER= RANS
KIND_TURB_MODEL= SA
KIND_TRANS_MODEL= LM
FREESTREAM_INTERMITTENCY= 1.0
FREESTREAM_TURBULENCEINTENSITY= 0.05
MACH_NUMBER= 0.8
AOA= 1.25
REF_DIMENSIONALIZATION= DIMENSIONAL
REF_LENGTH= 1.0
REF_AREA= 1.0
FREESTREAM_PRESSURE= 101325.0
FREESTREAM_TEMPERATURE= 288.15
REYNOLDS_NUMBER= 6.5E6
REYNOLDS_LENGTH= 1.0
MARKER_HEATFLUX= ( airfoil, 0.0 )
MARKER_FAR= ( farfield )
NUM_METHOD_GRAD= WEIGHTED_LEAST_SQUARES
CFL_NUMBER= 1.0
ITER= 5
LINEAR_SOLVER= FGMRES
LINEAR_SOLVER_ERROR= 1E-6
LINEAR_SOLVER_ITER= 5
CONV_NUM_METHOD_FLOW= JST
CONV_NUM_METHOD_TURB= SCALAR_UPWIND
MESH_FILENAME= ../../../QuickStart/mesh_NACA0012_inv.su2
MESH_FORMAT= SU2
SOLUTION_FILENAME= restart_flow.dat
RESTART_FILENAME= restart_flow_out.dat
RESTART_SOL= YES
CONV_FIELD= RMS_DENSITY
SCREEN_OUTPUT= (INNER_ITER, RMS_DENSITY, RMS_NU_TILDE, RMS_INTERMITTENCY, RMS_MOM_RE, LIFT, DRAG)