fix: Respect <base> tag for relative link resolution in html2text (#1680) #1721
+15
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
Fixes #1680
Details
The HTML2Text class was ignoring the
<base>tag, causing relative linksto be resolved against the initial page URL instead of the base URL
specified in the HTML document.
According to HTML standards, the
<base>element specifies the base URLfor all relative URLs in a document. This is commonly used in:
Changes
<base>tag detection and baseurl updateExample
Before:
https://example.com/index.php/page.html<base href="https://example.com/">files/document.pdfhttps://example.com/index.php/files/document.pdf❌After:
https://example.com/files/document.pdf✅Test plan
🤖 Generated with Claude Code