Skip to content

fix: Respect <base> tag for relative link resolution in html2text (#1680) #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YuriNachos wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −0
Open

fix: Respect <base> tag for relative link resolution in html2text (#1680) #1721

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions crawl4ai/html2text/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,12 @@ def handle_tag(
if self.tag_callback(self, tag, attrs, start) is True:
return

# Handle <base> tag to update base URL for relative links
if tag == "base" and start:
href = attrs.get("href")
if href:
self.baseurl = href

# first thing inside the anchor tag is another tag
# that produces some output
if (
Expand Down Expand Up @@ -1069,6 +1075,15 @@ def update_params(self, **kwargs):
setattr(self, key, value)

def handle_tag(self, tag, attrs, start):
# Handle <base> tag to update base URL for relative links
# Must be handled before preserved tags since <base> is in <head>
if tag == "base" and start:
href = attrs.get("href") if attrs else None
if href:
self.baseurl = href
# Also let parent class handle it
return super().handle_tag(tag, attrs, start)

# Handle preserved tags
if tag in self.preserve_tags:
if start:
Expand Down